Issue 408833003: Fix Android WebContents ExitFullscreen jni bridge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 408833003: Fix Android WebContents ExitFullscreen jni bridge. (Closed)

Created:
6 years, 5 months ago by ppi

Modified:
6 years, 5 months ago

Reviewers:
jdduke (slow), AKVT

CC:
chromium-reviews, darin-cc_chromium.org, jam, Yaron

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Fix Android WebContents ExitFullscreen jni bridge. Believe it or not, but the extraneous whitespace is confusing the JNI generator resulting in UnsatisfiedLinkError at runtime. TBR=jdduke@chromium.org BUG=395574 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284408

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

ppi

As this is trivial and blocking ToTs, I'm TBRing Jared and I will proceed with ...

6 years, 5 months ago (2014-07-21 11:12:04 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/408833003/1

6 years, 5 months ago (2014-07-21 11:13:19 UTC) #3

ppi

6 years, 5 months ago (2014-07-21 11:13:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r284408 (presubmit successful).