Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: Source/core/css/Pair.h

Issue 40883002: Remove virtual destructor for Pair class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. 3 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 26 matching lines...) Expand all
37 enum IdenticalValuesPolicy { DropIdenticalValues, KeepIdenticalValues }; 37 enum IdenticalValuesPolicy { DropIdenticalValues, KeepIdenticalValues };
38 38
39 static PassRefPtr<Pair> create() 39 static PassRefPtr<Pair> create()
40 { 40 {
41 return adoptRef(new Pair); 41 return adoptRef(new Pair);
42 } 42 }
43 static PassRefPtr<Pair> create(PassRefPtr<CSSPrimitiveValue> first, PassRefP tr<CSSPrimitiveValue> second, IdenticalValuesPolicy identicalValuesPolicy) 43 static PassRefPtr<Pair> create(PassRefPtr<CSSPrimitiveValue> first, PassRefP tr<CSSPrimitiveValue> second, IdenticalValuesPolicy identicalValuesPolicy)
44 { 44 {
45 return adoptRef(new Pair(first, second, identicalValuesPolicy)); 45 return adoptRef(new Pair(first, second, identicalValuesPolicy));
46 } 46 }
47 virtual ~Pair() { }
48 47
49 CSSPrimitiveValue* first() const { return m_first.get(); } 48 CSSPrimitiveValue* first() const { return m_first.get(); }
50 CSSPrimitiveValue* second() const { return m_second.get(); } 49 CSSPrimitiveValue* second() const { return m_second.get(); }
51 IdenticalValuesPolicy identicalValuesPolicy() const { return m_identicalValu esPolicy; } 50 IdenticalValuesPolicy identicalValuesPolicy() const { return m_identicalValu esPolicy; }
52 51
53 void setFirst(PassRefPtr<CSSPrimitiveValue> first) { m_first = first; } 52 void setFirst(PassRefPtr<CSSPrimitiveValue> first) { m_first = first; }
54 void setSecond(PassRefPtr<CSSPrimitiveValue> second) { m_second = second; } 53 void setSecond(PassRefPtr<CSSPrimitiveValue> second) { m_second = second; }
55 void setIdenticalValuesPolicy(IdenticalValuesPolicy identicalValuesPolicy) { m_identicalValuesPolicy = identicalValuesPolicy; } 54 void setIdenticalValuesPolicy(IdenticalValuesPolicy identicalValuesPolicy) { m_identicalValuesPolicy = identicalValuesPolicy; }
56 55
57 String cssText() const 56 String cssText() const
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 } 94 }
96 95
97 RefPtr<CSSPrimitiveValue> m_first; 96 RefPtr<CSSPrimitiveValue> m_first;
98 RefPtr<CSSPrimitiveValue> m_second; 97 RefPtr<CSSPrimitiveValue> m_second;
99 IdenticalValuesPolicy m_identicalValuesPolicy; 98 IdenticalValuesPolicy m_identicalValuesPolicy;
100 }; 99 };
101 100
102 } // namespace 101 } // namespace
103 102
104 #endif 103 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698