Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 408813004: PPAPI: Check for NULL before calling WebBindings::evaluate (Closed)

Created:
6 years, 5 months ago by dmichael (off chromium)
Modified:
6 years, 5 months ago
Reviewers:
teravest
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

PPAPI: Check for NULL before calling WebBindings::evaluate BUG=395288 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284779

Patch Set 1 #

Total comments: 2

Patch Set 2 : improve comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
dmichael (off chromium)
6 years, 5 months ago (2014-07-21 19:34:08 UTC) #1
teravest
https://codereview.chromium.org/408813004/diff/1/content/renderer/pepper/pepper_plugin_instance_impl.cc File content/renderer/pepper/pepper_plugin_instance_impl.cc (right): https://codereview.chromium.org/408813004/diff/1/content/renderer/pepper/pepper_plugin_instance_impl.cc#newcode2391 content/renderer/pepper/pepper_plugin_instance_impl.cc:2391: try_catch.SetException("No frame to execute script in."); This error message ...
6 years, 5 months ago (2014-07-21 19:38:04 UTC) #2
dmichael (off chromium)
https://codereview.chromium.org/408813004/diff/1/content/renderer/pepper/pepper_plugin_instance_impl.cc File content/renderer/pepper/pepper_plugin_instance_impl.cc (right): https://codereview.chromium.org/408813004/diff/1/content/renderer/pepper/pepper_plugin_instance_impl.cc#newcode2391 content/renderer/pepper/pepper_plugin_instance_impl.cc:2391: try_catch.SetException("No frame to execute script in."); On 2014/07/21 19:38:04, ...
6 years, 5 months ago (2014-07-21 19:57:47 UTC) #3
teravest
lgtm
6 years, 5 months ago (2014-07-21 19:58:11 UTC) #4
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 5 months ago (2014-07-21 19:58:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/408813004/20001
6 years, 5 months ago (2014-07-21 19:59:15 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 02:37:02 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 11:06:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/41441)
6 years, 5 months ago (2014-07-22 11:06:05 UTC) #9
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 5 months ago (2014-07-22 13:57:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/408813004/20001
6 years, 5 months ago (2014-07-22 13:58:29 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 19:17:03 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 21:27:49 UTC) #13
Message was sent while issue was closed. 
Change committed as 284779

Powered by Google App Engine
This is Rietveld 408576698