Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Issue 408813003: Do not run non-SFI NaCl tests under any sanitizer tools. (Closed)

Created:
6 years, 5 months ago by earthdok
Modified:
6 years, 5 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews, native-client-reviews_googlegroups.com, hamaji
Project:
chromium
Visibility:
Public.

Description

Do not run non-SFI NaCl tests under any sanitizer tools. The sandbox policy is too restrictive. BUG=395578 R=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M chrome/test/nacl/nacl_browsertest_util.h View 1 chunk +4 lines, -2 lines 0 comments Download
M components/nacl/loader/nonsfi/nonsfi_sandbox_sigsys_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
earthdok
please take a look
6 years, 5 months ago (2014-07-21 12:07:27 UTC) #1
Mark Seaborn
LGTM
6 years, 5 months ago (2014-07-21 22:29:42 UTC) #2
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 5 months ago (2014-07-22 08:53:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/408813003/1
6 years, 5 months ago (2014-07-22 08:54:06 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 09:42:48 UTC) #5
Message was sent while issue was closed.
Change committed as 284656

Powered by Google App Engine
This is Rietveld 408576698