Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: site/try/src/editor.dart

Issue 408783002: Enable Try Dart to run on IE11. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Added 'diagnostic' class to wrapper span, narrowed hover css application Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « site/try/src/compiler_isolate.dart ('k') | site/try/src/html_to_text.dart » ('j') | site/try/src/interaction_manager.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: site/try/src/editor.dart
===================================================================
--- site/try/src/editor.dart (revision 38889)
+++ site/try/src/editor.dart (working copy)
@@ -161,14 +161,15 @@
} else {
alert = info(message);
}
- Element parent = node.parent;
+ Element parent = node.parentNode;
if (parent.classes.contains("diagnostic") &&
!interaction.oldDiagnostics.contains(parent)) {
Element other = parent.firstChild;
other.remove();
- SpanElement wrapper = new SpanElement();
- wrapper.style
- ..fontWeight = 'normal';
+ SpanElement wrapper = new SpanElement()
+ ..classes.add('diagnostic')
+ ..style.fontWeight = 'normal';
+
var root = getShadowRoot(wrapper);
if (root is ShadowRoot) {
// When https://code.google.com/p/chromium/issues/detail?id=313458
« no previous file with comments | « site/try/src/compiler_isolate.dart ('k') | site/try/src/html_to_text.dart » ('j') | site/try/src/interaction_manager.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698