Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 408753002: [Mac] Re-Enable timer coalescing on Mac. (Closed)

Created:
6 years, 5 months ago by jeremy
Modified:
4 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul, tonyg, gab
Project:
chromium
Visibility:
Public.

Description

[Mac] Re-Enable timer coalescing on Mac. Disabled in r283311 to get a measurement on the effect on the bots. Re-Enabling because we've collected the data we need. BUG=356804 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M base/message_loop/message_pump_mac.mm View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
jeremy
6 years, 5 months ago (2014-07-20 11:31:30 UTC) #1
Mark Mentovai
LGTM
6 years, 5 months ago (2014-07-20 13:22:22 UTC) #2
jeremy
The CQ bit was checked by jeremy@chromium.org
6 years, 5 months ago (2014-07-20 13:38:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/408753002/1
6 years, 5 months ago (2014-07-20 13:39:54 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-20 15:28:45 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-20 17:13:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/40949)
6 years, 5 months ago (2014-07-20 17:13:52 UTC) #7
jeremy
The CQ bit was checked by jeremy@chromium.org
6 years, 5 months ago (2014-07-20 17:22:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/408753002/1
6 years, 5 months ago (2014-07-20 17:23:29 UTC) #9
commit-bot: I haz the power
Change committed as 284382
6 years, 5 months ago (2014-07-20 21:54:06 UTC) #10
gab
4 years, 1 month ago (2016-11-03 20:38:02 UTC) #12
Message was sent while issue was closed.
Looking into the advantage of timer slack these days (http://crbug.com/662015),
do you have a doc summarizing the data?

Powered by Google App Engine
This is Rietveld 408576698