Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 408733002: Fix RenderTextHarfBuzz glyph offset regression. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Restore hb_buffer_set_language call. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_harfbuzz.cc
diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc
index 8d332e3c147b737dfa3a311b6058c16fef1d080a..2fcf15711ff551377b09f42c903f9688eac29a5c 100644
--- a/ui/gfx/render_text_harfbuzz.cc
+++ b/ui/gfx/render_text_harfbuzz.cc
@@ -1011,7 +1011,8 @@ void RenderTextHarfBuzz::ShapeRunWithFont(internal::TextRunHarfBuzz* run,
hb_buffer_set_script(buffer, ICUScriptToHBScript(run->script));
hb_buffer_set_direction(buffer,
run->is_rtl ? HB_DIRECTION_RTL : HB_DIRECTION_LTR);
- // TODO(ckocagil): Should we call |hb_buffer_set_language()| here?
+ // TODO(ckocagil): Should we determine the actual language?
+ hb_buffer_set_language(buffer, hb_language_get_default());
behdad_google 2014/07/20 01:52:51 FWIW setting the language to default is not needed
// Shape the text.
hb_shape(harfbuzz_font, buffer, NULL, 0);
@@ -1033,7 +1034,7 @@ void RenderTextHarfBuzz::ShapeRunWithFont(internal::TextRunHarfBuzz* run,
SkScalarRoundToInt(SkFixedToScalar(hb_positions[i].x_offset));
const int y_offset =
SkScalarRoundToInt(SkFixedToScalar(hb_positions[i].y_offset));
- run->positions[i].set(run->width + x_offset, y_offset);
+ run->positions[i].set(run->width + x_offset, -y_offset);
run->width +=
SkScalarRoundToInt(SkFixedToScalar(hb_positions[i].x_advance));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698