ui/gfx/render_text_harfbuzz.cc - Issue 408733002: Fix RenderTextHarfBuzz glyph offset regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 408733002: Fix RenderTextHarfBuzz glyph offset regression. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/render_text_harfbuzz.cc

diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc

index 8d332e3c147b737dfa3a311b6058c16fef1d080a..363827a54265aae060eff492be9477afa7b75124 100644

--- a/ui/gfx/render_text_harfbuzz.cc

+++ b/ui/gfx/render_text_harfbuzz.cc

@@ -1033,7 +1033,7 @@ void RenderTextHarfBuzz::ShapeRunWithFont(internal::TextRunHarfBuzz* run,

SkScalarRoundToInt(SkFixedToScalar(hb_positions[i].x_offset));

const int y_offset =

SkScalarRoundToInt(SkFixedToScalar(hb_positions[i].y_offset));

- run->positions[i].set(run->width + x_offset, y_offset);

+ run->positions[i].set(run->width + x_offset, -y_offset);

run->width +=

SkScalarRoundToInt(SkFixedToScalar(hb_positions[i].x_advance));

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »