Fix RenderTextHarfBuzz glyph offset regression.

Fix RenderTextHarfBuzz glyph offset regression.

Negate the vertical glyph offset in RenderTextHarfBuzz.
Also restores the hb_buffer_set_language call and comment.
These were victims of merge errors in r284297.

BUG=391203
TEST=Arabic diacritics are drawn correctly.
R=ckocagil@chromium.org
TBR=asvitkine@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284356

[msw, 2014-07-19 23:33:27]

Landing this quick regression fix.

[ckocagil, 2014-07-19 23:35:22]

Oops, I have no idea how this merge error happened. Sorry for the trouble.

lgtm with comment

https://codereview.chromium.org/408733002/diff/1/ui/gfx/render_text_harfbuzz.cc
File ui/gfx/render_text_harfbuzz.cc (right):

https://codereview.chromium.org/408733002/diff/1/ui/gfx/render_text_harfbuzz....
ui/gfx/render_text_harfbuzz.cc:1014: // TODO(ckocagil): Should we call
|hb_buffer_set_language()| here?
Can you change this comment to the following 2 lines?

// TODO(ckocagil): Should we determine the actual language?
hb_buffer_set_language(buffer, hb_language_get_default());

[msw, 2014-07-20 00:08:20]

https://codereview.chromium.org/408733002/diff/1/ui/gfx/render_text_harfbuzz.cc
File ui/gfx/render_text_harfbuzz.cc (right):

https://codereview.chromium.org/408733002/diff/1/ui/gfx/render_text_harfbuzz....
ui/gfx/render_text_harfbuzz.cc:1014: // TODO(ckocagil): Should we call
|hb_buffer_set_language()| here?
On 2014/07/19 23:35:21, ckocagil wrote:
> Can you change this comment to the following 2 lines?
> 
> // TODO(ckocagil): Should we determine the actual language?
> hb_buffer_set_language(buffer, hb_language_get_default());

Done.

[msw, 2014-07-20 00:08:56]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2014-07-20 00:10:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/msw@chromium.org/408733002/20001

[behdad_google, 2014-07-20 01:52:51]

https://codereview.chromium.org/408733002/diff/20001/ui/gfx/render_text_harfb...
File ui/gfx/render_text_harfbuzz.cc (right):

https://codereview.chromium.org/408733002/diff/20001/ui/gfx/render_text_harfb...
ui/gfx/render_text_harfbuzz.cc:1015: hb_buffer_set_language(buffer,
hb_language_get_default());
FWIW setting the language to default is not needed.

[commit-bot: I haz the power, 2014-07-20 02:25:22]

Change committed as 284356

[Alexei Svitkine (slow), 2014-07-21 14:05:23]

lgtm