Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 408683002: flex shorthand incorrectly accepting 1 auto 1 (i.e. flex-basis in the middle) (Closed)

Created:
6 years, 5 months ago by harpreet.sk
Modified:
6 years, 5 months ago
CC:
blink-reviews, cbiesinger, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

flex shorthand incorrectly accepting 1 auto 1 (i.e. flex-basis in the middle) This patch is in continuation with the given CL https://codereview.chromium.org/396263003/ which fixes the bug of flex shorthand incorrectly accepting values in which flex-basis is in the middle and does not have value "auto". It does not took care of the case 1 auto 1 which according to the grammar of te flex shorthand is incorrect. This patch is adding support for the given missed case "1 auto 1" by modifying the condition to check for if flex-basis is in the middle or not in the argument list for all the different types of values of flex-basis. BUG=380984 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178738

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M LayoutTests/css3/flexbox/flex-property-parsing.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-property-parsing-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-shorthand-flex-basis-middle.html View 2 chunks +9 lines, -4 lines 0 comments Download
M LayoutTests/css3/flexbox/flex-shorthand-flex-basis-middle-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
harpreet.sk
Sorry i missed this case in previous patch.... ptal...
6 years, 5 months ago (2014-07-19 13:33:24 UTC) #1
tony
Please add a test case to css3/flexbox/flex-property-parsing.html.
6 years, 5 months ago (2014-07-21 16:17:56 UTC) #2
harpreet.sk
On 2014/07/21 16:17:56, tony wrote: > Please add a test case to css3/flexbox/flex-property-parsing.html. Test case ...
6 years, 5 months ago (2014-07-22 11:25:18 UTC) #3
tony
LGTM
6 years, 5 months ago (2014-07-22 17:21:01 UTC) #4
harpreet.sk
@leviw - require owner's lgtm
6 years, 5 months ago (2014-07-22 18:06:56 UTC) #5
leviw_travelin_and_unemployed
rslgtm
6 years, 5 months ago (2014-07-22 18:19:23 UTC) #6
harpreet.sk
The CQ bit was checked by harpreet.sk@samsung.com
6 years, 5 months ago (2014-07-22 18:37:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harpreet.sk@samsung.com/408683002/20001
6 years, 5 months ago (2014-07-22 18:38:26 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-22 20:22:51 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 21:14:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/30986)
6 years, 5 months ago (2014-07-22 21:14:25 UTC) #11
harpreet.sk
The CQ bit was checked by harpreet.sk@samsung.com
6 years, 5 months ago (2014-07-23 06:43:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harpreet.sk@samsung.com/408683002/20001
6 years, 5 months ago (2014-07-23 06:43:51 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 06:44:41 UTC) #14
Message was sent while issue was closed.
Change committed as 178738

Powered by Google App Engine
This is Rietveld 408576698