Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: trunk/src/content/browser/renderer_host/render_widget_host_view_android.cc

Issue 408663006: Revert 284065 "Revert of Revert of Migrate accessibility from Re..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/browser/renderer_host/render_widget_host_view_android.cc
===================================================================
--- trunk/src/content/browser/renderer_host/render_widget_host_view_android.cc (revision 284469)
+++ trunk/src/content/browser/renderer_host/render_widget_host_view_android.cc (working copy)
@@ -1150,16 +1150,20 @@
content_view_core_->GetWindowAndroid()->RequestVSyncUpdate();
}
-BrowserAccessibilityManager*
- RenderWidgetHostViewAndroid::CreateBrowserAccessibilityManager(
- BrowserAccessibilityDelegate* delegate) {
- base::android::ScopedJavaLocalRef<jobject> obj;
- if (content_view_core_)
- obj = content_view_core_->GetJavaObject();
- return new BrowserAccessibilityManagerAndroid(
- obj,
- BrowserAccessibilityManagerAndroid::GetEmptyDocument(),
- delegate);
+void RenderWidgetHostViewAndroid::CreateBrowserAccessibilityManagerIfNeeded() {
+ if (!host_ || host_->accessibility_mode() != AccessibilityModeComplete)
+ return;
+
+ if (!GetBrowserAccessibilityManager()) {
+ base::android::ScopedJavaLocalRef<jobject> obj;
+ if (content_view_core_)
+ obj = content_view_core_->GetJavaObject();
+ SetBrowserAccessibilityManager(
+ new BrowserAccessibilityManagerAndroid(
+ obj,
+ BrowserAccessibilityManagerAndroid::GetEmptyDocument(),
+ host_));
+ }
}
bool RenderWidgetHostViewAndroid::LockMouse() {
@@ -1264,14 +1268,12 @@
content_view_core_ = content_view_core;
- BrowserAccessibilityManager* manager = NULL;
- if (host_)
- manager = host_->GetRootBrowserAccessibilityManager();
- if (manager) {
+ if (GetBrowserAccessibilityManager()) {
base::android::ScopedJavaLocalRef<jobject> obj;
if (content_view_core_)
obj = content_view_core_->GetJavaObject();
- manager->ToBrowserAccessibilityManagerAndroid()->SetContentViewCore(obj);
+ GetBrowserAccessibilityManager()->ToBrowserAccessibilityManagerAndroid()->
+ SetContentViewCore(obj);
}
AttachLayers();

Powered by Google App Engine
This is Rietveld 408576698