OLD | NEW |
---|---|
(Empty) | |
1 // Copyright 2014 The Chromium Authors. All rights reserved. | |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 #ifndef NavigatorPresentation_h | |
6 #define NavigatorPresentation_h | |
7 | |
8 #include "core/frame/DOMWindowProperty.h" | |
9 #include "modules/presentation/Presentation.h" | |
10 #include "platform/Supplementable.h" | |
11 | |
12 namespace blink { | |
13 | |
14 class Navigator; | |
15 class Presentation; | |
Peter Beverloo
2014/07/25 18:01:18
nit: You include Presentation.h, so no need to for
whywhat
2014/08/19 18:07:35
Removed the header. Prefer to forward declare.
| |
16 | |
17 class NavigatorPresentation FINAL | |
18 : public GarbageCollectedFinalized<NavigatorPresentation> | |
Peter Beverloo
2014/07/25 18:01:18
mmm. It looks like every other module defining a p
whywhat
2014/08/19 18:07:35
Done.
| |
19 , public WillBeHeapSupplement<Navigator> | |
20 , public DOMWindowProperty { | |
Peter Beverloo
2014/07/25 18:01:17
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(NavigatorPre
whywhat
2014/08/19 18:07:35
Done.
| |
21 public: | |
22 virtual ~NavigatorPresentation(); | |
23 | |
24 static NavigatorPresentation& from(Navigator&); | |
25 static Presentation& presentation(Navigator&); | |
26 | |
27 void trace(Visitor*) OVERRIDE; | |
Peter Beverloo
2014/07/25 18:01:18
This should be virtual. The method will in fact be
whywhat
2014/08/19 18:07:35
Done.
| |
28 | |
29 private: | |
30 static const char* supplementName(); | |
31 | |
32 NavigatorPresentation(LocalFrame*); | |
Peter Beverloo
2014/07/25 18:01:17
Constructors with only one argument should be mark
whywhat
2014/08/19 18:07:34
Done.
| |
33 | |
34 Presentation& presentation(); | |
35 | |
36 PersistentWillBeMember<Presentation> m_presentation; | |
Peter Beverloo
2014/07/25 18:01:17
s/PersistentWillBeMember/Member/?
whywhat
2014/08/19 18:07:34
Nah, let's go for consistency.
| |
37 }; | |
38 | |
39 } // namespace blink | |
40 | |
41 #endif // NavigatorPresentation_h | |
OLD | NEW |