Add the Presentation API module and a single event target

Source/modules/presentation/NavigatorPresentation.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NavigatorPresentation_h
+#define NavigatorPresentation_h
+
+#include "core/frame/DOMWindowProperty.h"
+#include "modules/presentation/Presentation.h"
+#include "platform/Supplementable.h"
+
+namespace WebCore {

[Peter Beverloo, 2014/07/19 10:16:12]

nit: s/WebCore/blink/

Elsewhere too, we switched namespaces :-).

[whywhat, 2014/07/23 00:39:25]

Done.

+
+class Navigator;
+class Presentation;
+
+class NavigatorPresentation FINAL
+    : public NoBaseWillBeGarbageCollectedFinalized<NavigatorPresentation>

[Peter Beverloo, 2014/07/19 10:16:12]

No need to use the Oilpan transitional types, you may as well declare this as
being GarbageCollectedFinalized<>.

[whywhat, 2014/07/23 00:39:26]

It seems like I have to use WillBeHeapSupplement with Navigator for some reason,
it doesn't compile if using plain HeapSupplement (maybe I need to add blink::
since that's what WillBeHeapSupplement is)?

Done for the other classes.

+    , public WillBeHeapSupplement<Navigator>
+    , public DOMWindowProperty {
+    WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(NavigatorPresentation);
+public:
+    virtual ~NavigatorPresentation();
+
+    static NavigatorPresentation& from(Navigator&);
+    static Presentation* presentation(Navigator&);
+
+    Presentation* presentation() const;

[Peter Beverloo, 2014/07/19 10:16:12]

You could also make this private since there are no callers outside of the
static ::presentation method.

[Peter Beverloo, 2014/07/19 10:16:12]

nit: This shouldn't be |const| since it can modify |m_presentation|, which
shouldn't be declared as mutable (even though this still is somewhat common).

[whywhat, 2014/07/23 00:39:25]

Done.

[whywhat, 2014/07/23 00:39:26]

Done.

+
+    void trace(Visitor*);

[Peter Beverloo, 2014/07/19 10:16:12]

virtual void trace(Visitor*) OVERRIDE;

[whywhat, 2014/07/23 00:39:25]

Done.

+
+private:
+    static const char* supplementName();
+
+    NavigatorPresentation(LocalFrame*);
+
+    mutable PersistentWillBeMember<Presentation> m_presentation;
+};
+
+} // namespace WebCore
+
+#endif // Presentation_h

[Peter Beverloo, 2014/07/19 10:16:12]

nit: NavigatorPresentation_h

[whywhat, 2014/07/23 00:39:26]

Done.