git_cache.py - Issue 408653002: Git Cache speculative fix for windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cache.py

Issue 408653002: Git Cache speculative fix for windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: git_cache.py

diff --git a/git_cache.py b/git_cache.py

index ae8a5194878ac98f69bf0fcee1558fcec147837d..320d2de00b3ded9e4ca2ba5346cc041339a81e62 100755

--- a/git_cache.py

+++ b/git_cache.py

@@ -406,7 +406,11 @@ class Mirror(object):

self._fetch(tempdir or self.mirror_path, verbose, depth)

finally:

if tempdir:

- os.rename(tempdir, self.mirror_path)

+ try:

+ os.rename(tempdir, self.mirror_path)

+ except WindowsError:

+ # This is somehow racy on Windows.

iannucci 2014/07/19 01:00:52 this will rely on the unlock all functionality in

+ pass

if not ignore_lock:

lockfile.unlock()

« no previous file with comments | « no previous file | no next file » | no next file with comments »