Issue 408643002: Implement full-screen browser-test for apps v1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 408643002: Implement full-screen browser-test for apps v1. (Closed)

Created:
6 years, 5 months ago by Jamie

Modified:
6 years, 5 months ago

Reviewers:
weitao

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Implement full-screen browser-test for apps v1. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284562

Patch Set 2 : Reviewer feedback. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -0 lines)			Patch
	M	chrome/test/remoting/me2me_browsertest.cc	View	1	3 chunks	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

weitao

LGTM after my comment is addressed. https://codereview.chromium.org/408643002/diff/1/chrome/test/remoting/me2me_browsertest.cc File chrome/test/remoting/me2me_browsertest.cc (right): https://codereview.chromium.org/408643002/diff/1/chrome/test/remoting/me2me_browsertest.cc#newcode207 chrome/test/remoting/me2me_browsertest.cc:207: base::TimeDelta::FromSeconds(10), Please fix ...

6 years, 5 months ago (2014-07-21 17:23:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/408643002/20001

6 years, 5 months ago (2014-07-21 19:25:26 UTC) #4

Message was sent while issue was closed.

Change committed as 284562

Expand Messages | Collapse Messages

Issue 408643002: Implement full-screen browser-test for apps v1. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Reviewer feedback. #

Messages