Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2291)

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java

Issue 40863003: Issue 14388. Remove implicit setters for final fields. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java
diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java
index 40706c7bd48a7475ed45459294f3dfc4c8b41db8..87dde658acd309345662b11629c1950b3d363488 100644
--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java
+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java
@@ -566,22 +566,6 @@ public class StaticWarningCodeTest extends ResolverTestCase {
verify(source);
}
- public void test_assignmentToFinal_excludedSetter() throws Exception {
- Source source = addSource(createSource(//
- "class A {",
- " var v;",
- "}",
- "class B extends A {",
- " final v = 0;",
- "}",
- "main() {",
- " new B().v = 1;",
- "}"));
- resolve(source);
- assertErrors(source, StaticWarningCode.ASSIGNMENT_TO_FINAL);
- verify(source);
- }
-
public void test_assignmentToFinal_instanceVariable() throws Exception {
Source source = addSource(createSource(//
"class A {",
@@ -1796,19 +1780,6 @@ public class StaticWarningCodeTest extends ResolverTestCase {
verify(source);
}
- public void test_nonAbstractClassInheritsAbstractMemberOne_setter_excluded() throws Exception {
- Source source = addSource(createSource(//
- "class A {",
- " final int x = 0;",
- "}",
- "class B implements A {",
- " int get x => 42;",
- "}"));
- resolve(source);
- assertErrors(source, StaticWarningCode.NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_ONE);
- verify(source);
- }
-
public void test_nonAbstractClassInheritsAbstractMemberOne_setter_fromInterface()
throws Exception {
Source source = addSource(createSource(//

Powered by Google App Engine
This is Rietveld 408576698