Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java

Issue 40863003: Issue 14388. Remove implicit setters for final fields. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java
index 15bab3557e46fec4a6dbe79f656dfa4afd45f8c7..bef3128649b3c5392e3bb026282c7a6c9ee7f360 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java
@@ -760,18 +760,20 @@ public class ElementBuilder extends RecursiveASTVisitor<Void> {
currentHolder.addAccessor(getter);
variable.setGetter(getter);
- PropertyAccessorElementImpl setter = new PropertyAccessorElementImpl(variable);
- setter.setSetter(true);
- setter.setStatic(variable.isStatic());
- ParameterElementImpl parameter = new ParameterElementImpl(
- "_" + variable.getName(),
- variable.getNameOffset());
- parameter.setSynthetic(true);
- parameter.setParameterKind(ParameterKind.REQUIRED);
- setter.setParameters(new ParameterElement[] {parameter});
-
- currentHolder.addAccessor(setter);
- variable.setSetter(setter);
+ if (!isFinal) {
+ PropertyAccessorElementImpl setter = new PropertyAccessorElementImpl(variable);
+ setter.setSetter(true);
+ setter.setStatic(variable.isStatic());
+ ParameterElementImpl parameter = new ParameterElementImpl(
+ "_" + variable.getName(),
+ variable.getNameOffset());
+ parameter.setSynthetic(true);
+ parameter.setParameterKind(ParameterKind.REQUIRED);
+ setter.setParameters(new ParameterElement[] {parameter});
+
+ currentHolder.addAccessor(setter);
+ variable.setSetter(setter);
+ }
}
return null;
}

Powered by Google App Engine
This is Rietveld 408576698