Minimize HomeCard if the user opens something in the home card.

Minimize HomeCard if the user opens something in the home card.

This is applied to:
- open to the search result
- click on app icon

I am not sure this is the right approach. We may want to introduce
an ActivityObserver or something, and minimize the home card
by itself. However, activity may be created for various reason
but minimizing should work upon the user's action on the
home card, so this approach isn't bad.

BUG=None
R=oshima@chromium.org, sadrul@chromium.org
TBR=sky@chromium.org
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284962

[sadrul, 2014-07-19 17:56:22]

A different approach could be to override
WindowObserver::OnWindowStackingChanged() from WindowManagerImpl, and trigger
some callback in WindowManagerObserver. Would that work?

[Jun Mukai, 2014-07-21 22:19:00]

On 2014/07/19 17:56:22, sadrul wrote:
> A different approach could be to override
> WindowObserver::OnWindowStackingChanged() from WindowManagerImpl, and trigger
> some callback in WindowManagerObserver. Would that work?

Looked around the code base and noticed ActivationChangeObserver would be
best-fitting to this scenario. Changed to use this observer. PTAL.

[sadrul, 2014-07-22 16:58:27]

Cool. LGTM

[oshima, 2014-07-22 17:59:50]

is it possible to write a test in athena_unittests?

[Jun Mukai, 2014-07-22 21:30:16]

added tests. ptal.

[oshima, 2014-07-22 21:48:38]

https://codereview.chromium.org/408623003/diff/60001/athena/home/home_card_un...
File athena/home/home_card_unittest.cc (right):

https://codereview.chromium.org/408623003/diff/60001/athena/home/home_card_un...
athena/home/home_card_unittest.cc:25:
app_list::switches::kEnableExperimentalAppList);
please move this to the helper as discussed offline.

https://codereview.chromium.org/408623003/diff/60001/athena/home/home_card_un...
athena/home/home_card_unittest.cc:83: }  // namespace
please move the tests out from anonymous namespace because test names are
supposed to be unique in one unit test binary.

https://codereview.chromium.org/408623003/diff/60001/athena/home/public/home_...
File athena/home/public/home_card.h (right):

https://codereview.chromium.org/408623003/diff/60001/athena/home/public/home_...
athena/home/public/home_card.h:47: // Update/get the current state of the home
card to |state|.
Updates/gets

[Jun Mukai, 2014-07-22 21:57:57]

https://codereview.chromium.org/408623003/diff/60001/athena/home/home_card_un...
File athena/home/home_card_unittest.cc (right):

https://codereview.chromium.org/408623003/diff/60001/athena/home/home_card_un...
athena/home/home_card_unittest.cc:25:
app_list::switches::kEnableExperimentalAppList);
On 2014/07/22 21:48:38, oshima wrote:
> please move this to the helper as discussed offline.

Done.

https://codereview.chromium.org/408623003/diff/60001/athena/home/home_card_un...
athena/home/home_card_unittest.cc:83: }  // namespace
On 2014/07/22 21:48:37, oshima wrote:
> please move the tests out from anonymous namespace because test names are
> supposed to be unique in one unit test binary.

Done.

https://codereview.chromium.org/408623003/diff/60001/athena/home/public/home_...
File athena/home/public/home_card.h (right):

https://codereview.chromium.org/408623003/diff/60001/athena/home/public/home_...
athena/home/public/home_card.h:47: // Update/get the current state of the home
card to |state|.
On 2014/07/22 21:48:38, oshima wrote:
> Updates/gets

Done.

[oshima, 2014-07-22 22:12:30]

lgtm

[Jun Mukai, 2014-07-22 22:34:20]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-07-22 22:36:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/408623003/80001

[commit-bot: I haz the power, 2014-07-23 02:37:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-23 02:41:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 02:41:15]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Jun Mukai, 2014-07-23 16:41:19]

The CQ bit was checked by mukai@chromium.org

[Jun Mukai, 2014-07-23 16:41:43]

TBR=sky for adding dependency from athena/home to ui/wm/public

[commit-bot: I haz the power, 2014-07-23 16:44:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/408623003/80001

[commit-bot: I haz the power, 2014-07-23 16:59:24]

Change committed as 284962