Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 408583002: Fix for Android >= api level 19. (Closed)

Created:
6 years, 5 months ago by zra
Modified:
6 years, 3 months ago
Reviewers:
wtc, wtc1
CC:
chromium-reviews
Visibility:
Public.

Description

Fix for Android > api level 19. After 19, the NDK includes mmap64.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M nspr/pr/src/md/unix/unix.c View 3 chunks +8 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
zra
Not sure if you want to take this, or if anyone else is working on ...
6 years, 5 months ago (2014-07-18 22:43:50 UTC) #1
zra
6 years, 5 months ago (2014-07-21 23:00:08 UTC) #2
wtc
Thank you for the patch. Can I just check in this change to the NSPR ...
6 years, 5 months ago (2014-07-22 23:45:12 UTC) #3
wtc
I checked in your patch to the NSPR upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1042408 I will take care of ...
6 years, 5 months ago (2014-07-23 00:05:15 UTC) #4
zra
On 2014/07/23 00:05:15, wtc wrote: > I checked in your patch to the NSPR upstream: ...
6 years, 3 months ago (2014-09-03 16:49:45 UTC) #5
wtc
On 2014/09/03 16:49:45, zra wrote: > > Have you had a chance to update third_party/nss/nspr? ...
6 years, 3 months ago (2014-09-04 17:49:22 UTC) #6
zra
6 years, 3 months ago (2014-09-04 18:01:56 UTC) #7
On 2014/09/04 17:49:22, wtc wrote:
> On 2014/09/03 16:49:45, zra wrote:
> >
> > Have you had a chance to update third_party/nss/nspr?
> 
> It seems that I was planning to do that, but for some reason
> didn't do the last step that actually contains your change.
> Sorry!
> 
> I will take care of this today.

Thanks!

Powered by Google App Engine
This is Rietveld 408576698