Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 408563003: WebAudio: Add SSE2 optimization for DirectConvolver (Closed)

Created:
6 years, 5 months ago by Raymond Toy
Modified:
6 years, 5 months ago
CC:
blink-reviews, Raymond Toy
Project:
blink
Visibility:
Public.

Description

WebAudio: Add SSE2 optimization for DirectConvolver Benchmark result from http://rtoy.github.io/webaudio-hacks/tests/time-convolver-short.html, running Linux on a Z620: M36: 1680 ms Opt: 1060 ms Time is now reduced by about 33%. For Windows running on a Z600: M38: 3005 ms Opt: 2280 ms A savings of about 25%. BUG=395276 TESTS=convolution-mono-mono still passes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178576

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : Apply comments and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M Source/platform/audio/DirectConvolver.cpp View 1 2 4 chunks +48 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Raymond Toy
PTAL
6 years, 5 months ago (2014-07-18 23:11:38 UTC) #1
Ken Russell (switch to Gerrit)
LGTM https://codereview.chromium.org/408563003/diff/20001/Source/platform/audio/DirectConvolver.cpp File Source/platform/audio/DirectConvolver.cpp (right): https://codereview.chromium.org/408563003/diff/20001/Source/platform/audio/DirectConvolver.cpp#newcode43 Source/platform/audio/DirectConvolver.cpp:43: #include <emmintrin.h> This header's available on all non-Mac ...
6 years, 5 months ago (2014-07-19 01:02:25 UTC) #2
Raymond Toy
https://codereview.chromium.org/408563003/diff/20001/Source/platform/audio/DirectConvolver.cpp File Source/platform/audio/DirectConvolver.cpp (right): https://codereview.chromium.org/408563003/diff/20001/Source/platform/audio/DirectConvolver.cpp#newcode43 Source/platform/audio/DirectConvolver.cpp:43: #include <emmintrin.h> On 2014/07/19 01:02:24, Ken Russell wrote: > ...
6 years, 5 months ago (2014-07-21 17:09:57 UTC) #3
Raymond Toy
The CQ bit was checked by rtoy@chromium.org
6 years, 5 months ago (2014-07-21 18:18:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@chromium.org/408563003/40001
6 years, 5 months ago (2014-07-21 18:19:19 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 18:41:11 UTC) #6
Message was sent while issue was closed.
Change committed as 178576

Powered by Google App Engine
This is Rietveld 408576698