Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 408543002: Actually paint squashed layers when printing. (Closed)

Created:
6 years, 5 months ago by chrishtr
Modified:
6 years, 5 months ago
Reviewers:
ojan
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Actually paint squashed layers when printing. BUG=391662 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178532

Patch Set 1 #

Total comments: 7

Patch Set 2 : Cleanup. #

Patch Set 3 : Added test expectation rebaselines. #

Patch Set 4 : Added disabler. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -18 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/compositing/squashing/squashing-print.html View 1 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/platform/linux/compositing/squashing/squashing-print-expected.png View Binary file 0 comments Download
A LayoutTests/platform/linux/compositing/squashing/squashing-print-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 3 5 chunks +22 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
chrishtr
6 years, 5 months ago (2014-07-18 20:17:20 UTC) #1
ojan
lgtm https://codereview.chromium.org/408543002/diff/1/LayoutTests/compositing/squashing/squashing-print.html File LayoutTests/compositing/squashing/squashing-print.html (right): https://codereview.chromium.org/408543002/diff/1/LayoutTests/compositing/squashing/squashing-print.html#newcode1 LayoutTests/compositing/squashing/squashing-print.html:1: <!doctype html> Nit: DOCTYPE https://codereview.chromium.org/408543002/diff/1/LayoutTests/compositing/squashing/squashing-print.html#newcode8 LayoutTests/compositing/squashing/squashing-print.html:8: <div style="position: ...
6 years, 5 months ago (2014-07-18 21:27:31 UTC) #2
chrishtr
https://codereview.chromium.org/408543002/diff/1/LayoutTests/compositing/squashing/squashing-print.html File LayoutTests/compositing/squashing/squashing-print.html (right): https://codereview.chromium.org/408543002/diff/1/LayoutTests/compositing/squashing/squashing-print.html#newcode1 LayoutTests/compositing/squashing/squashing-print.html:1: <!doctype html> On 2014/07/18 21:27:31, ojan-only-code-yellow-reviews wrote: > Nit: ...
6 years, 5 months ago (2014-07-18 21:40:21 UTC) #3
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 5 months ago (2014-07-18 21:40:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/408543002/20001
6 years, 5 months ago (2014-07-18 21:41:13 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-18 23:22:25 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 23:46:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/35939)
6 years, 5 months ago (2014-07-18 23:46:39 UTC) #8
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 5 months ago (2014-07-21 02:04:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/408543002/60001
6 years, 5 months ago (2014-07-21 02:04:59 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 02:46:37 UTC) #11
Message was sent while issue was closed. 
Change committed as 178532

Powered by Google App Engine
This is Rietveld 408576698