Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 408523004: fix fine_grained_acl_list in upload_dir_contents(), and add unittest (Closed)

Created:
6 years, 5 months ago by epoger
Modified:
6 years, 5 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/common.git@master
Visibility:
Public.

Description

fix fine_grained_acl_list in upload_dir_contents(), and add unittest TBR=rmistry Committed: https://skia.googlesource.com/common/+/fb32c5f

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M py/utils/gs_utils.py View 4 chunks +22 lines, -9 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
epoger
committing TBR https://codereview.chromium.org/408523004/diff/1/py/utils/gs_utils.py File py/utils/gs_utils.py (right): https://codereview.chromium.org/408523004/diff/1/py/utils/gs_utils.py#newcode229 py/utils/gs_utils.py:229: fine_grained_acl_list=fine_grained_acl_list) whoops https://codereview.chromium.org/408523004/diff/1/py/utils/gs_utils.py#newcode640 py/utils/gs_utils.py:640: gs.upload_dir_contents( This was ...
6 years, 5 months ago (2014-07-18 20:41:26 UTC) #1
epoger
Committed patchset #1 manually as rfb32c5f (presubmit successful).
6 years, 5 months ago (2014-07-18 20:41:42 UTC) #2
rmistry
6 years, 5 months ago (2014-07-21 11:43:06 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698