Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 408523002: Really disable clang's SLP vectorizer on Linux. (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 5 months ago
Reviewers:
skobes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Really disable clang's SLP vectorizer on Linux. Follow-up to https://codereview.chromium.org/393193003/ . -fno-slp-vectorize was passed before -O2 on linux, and -O2 would reenable it. I checked that the order of -O3 and -fno-slp-vectorize is correct as-is on Mac. BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284191

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M build/common.gypi View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
6 years, 5 months ago (2014-07-18 18:59:49 UTC) #1
skobes
lgtm
6 years, 5 months ago (2014-07-18 19:24:19 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 5 months ago (2014-07-18 19:32:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/408523002/1
6 years, 5 months ago (2014-07-18 19:34:31 UTC) #4
Nico
The CQ bit was unchecked by thakis@chromium.org
6 years, 5 months ago (2014-07-18 20:09:42 UTC) #5
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 5 months ago (2014-07-18 20:09:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/408523002/1
6 years, 5 months ago (2014-07-18 20:12:54 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 20:14:55 UTC) #8
Message was sent while issue was closed.
Change committed as 284191

Powered by Google App Engine
This is Rietveld 408576698