Make Clone, Contains, Equal and IPC function non-virtual and implement in manifest_permission.cc

extensions/common/permissions/manifest_permission.h

Index: extensions/common/permissions/manifest_permission.h
diff --git a/extensions/common/permissions/manifest_permission.h b/extensions/common/permissions/manifest_permission.h
index af9e0357037f56e6e9a82f6e0142587edd1960ab..c801209e9aa04b0983ffdf1c5a997fc8e9c07924 100644
--- a/extensions/common/permissions/manifest_permission.h
+++ b/extensions/common/permissions/manifest_permission.h
@@ -50,7 +50,7 @@ class ManifestPermission {
   virtual scoped_ptr<base::Value> ToValue() const = 0;
 
   // Clones this.

[not at google - send to devlin, 2014/07/18 17:41:18]

you should add comments for all of these functions which are implemented by
default, or even better, move them into a bunch with a generic comment. I mean
like:

// These functions have already been implemented for you due to yada yada,
// but maybe you insist on implementing them yourselves.

or even better, just don't make them virtual as discussed.

[aboxhall, 2014/07/18 21:08:52]

Done (made them non-virtual).

-  virtual ManifestPermission* Clone() const = 0;
+  virtual ManifestPermission* Clone() const;
 
   // Returns a new manifest permission which equals this - |rhs|.
   virtual ManifestPermission* Diff(const ManifestPermission* rhs) const = 0;
@@ -64,20 +64,20 @@ class ManifestPermission {
       const = 0;
 
   // Returns true if |rhs| is a subset of this.
-  virtual bool Contains(const ManifestPermission* rhs) const = 0;
+  virtual bool Contains(const ManifestPermission* rhs) const;
 
   // Returns true if |rhs| is equal to this.
   virtual bool Equal(const ManifestPermission* rhs) const = 0;

[not at google - send to devlin, 2014/07/18 17:41:17]

you should be able to implement Equal as well?

[aboxhall, 2014/07/18 21:08:52]

Done.

 
   // IPC functions
   // Writes this into the given IPC message |m|.
-  virtual void Write(IPC::Message* m) const = 0;
+  virtual void Write(IPC::Message* m) const;
 
   // Reads from the given IPC message |m|.
-  virtual bool Read(const IPC::Message* m, PickleIterator* iter) = 0;
+  virtual bool Read(const IPC::Message* m, PickleIterator* iter);
 
   // Logs this permission.
-  virtual void Log(std::string* log) const = 0;
+  virtual void Log(std::string* log) const;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ManifestPermission);