Make Clone, Contains, Equal and IPC function non-virtual and implement in manifest_permission.cc

chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/manifest_handlers/ui_overrides_handler.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
@@ skipping 45 matching lines @@
 
   virtual bool FromValue(const base::Value* value) OVERRIDE {
     return value && value->GetAsBoolean(&override_bookmarks_ui_permission_);
   }
 
   virtual scoped_ptr<base::Value> ToValue() const OVERRIDE {
     return scoped_ptr<base::Value>(
         new base::FundamentalValue(override_bookmarks_ui_permission_)).Pass();
   }
 
-  virtual ManifestPermission* Clone() const OVERRIDE {
-    return scoped_ptr<ManifestPermissionImpl>(
-        new ManifestPermissionImpl(
-            override_bookmarks_ui_permission_)).release();
-  }
-
   virtual ManifestPermission* Diff(const ManifestPermission* rhs) const
       OVERRIDE {
     const ManifestPermissionImpl* other =
         static_cast<const ManifestPermissionImpl*>(rhs);
 
     return scoped_ptr<ManifestPermissionImpl>(new ManifestPermissionImpl(
         override_bookmarks_ui_permission_ &&
         !other->override_bookmarks_ui_permission_)).release();
   }
 
@@ skipping 10 matching lines @@
   virtual ManifestPermission* Intersect(const ManifestPermission* rhs) const
       OVERRIDE {
     const ManifestPermissionImpl* other =
         static_cast<const ManifestPermissionImpl*>(rhs);
 
     return scoped_ptr<ManifestPermissionImpl>(new ManifestPermissionImpl(
         override_bookmarks_ui_permission_ &&
         other->override_bookmarks_ui_permission_)).release();
   }
 
-  virtual bool Contains(const ManifestPermission* rhs) const OVERRIDE {
-    const ManifestPermissionImpl* other =
-        static_cast<const ManifestPermissionImpl*>(rhs);
-
-    return !other->override_bookmarks_ui_permission_ ||
-        override_bookmarks_ui_permission_;
-  }
-
-  virtual bool Equal(const ManifestPermission* rhs) const OVERRIDE {
-    const ManifestPermissionImpl* other =
-        static_cast<const ManifestPermissionImpl*>(rhs);
-
-    return override_bookmarks_ui_permission_ ==
-        other->override_bookmarks_ui_permission_;
-  }
-
-  virtual void Write(IPC::Message* m) const OVERRIDE {
-    IPC::WriteParam(m, override_bookmarks_ui_permission_);
-  }
-
-  virtual bool Read(const IPC::Message* m, PickleIterator* iter) OVERRIDE {
-    return IPC::ReadParam(m, iter, &override_bookmarks_ui_permission_);
-  }
-
-  virtual void Log(std::string* log) const OVERRIDE {
-    IPC::LogParam(override_bookmarks_ui_permission_, log);
-  }
-
  private:
   bool override_bookmarks_ui_permission_;
 };
 
 UIOverrides::UIOverrides() {}
 
 UIOverrides::~UIOverrides() {}
 
 const UIOverrides* UIOverrides::Get(const Extension* extension) {
   return static_cast<UIOverrides*>(
@@ skipping 74 matching lines @@
   const UIOverrides* data = UIOverrides::Get(extension);
   if (data)
     return data->manifest_permission->Clone();
   return NULL;
 }
 const std::vector<std::string> UIOverridesHandler::Keys() const {
   return SingleKey(manifest_keys::kUIOverride);
 }
 
 }  // namespace extensions