Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 408463003: Remove harmony-typeof (Closed)

Created:
6 years, 5 months ago by arv (Not doing code reviews)
Modified:
6 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove harmony-typeof This was an early experiment in the Harmony era that turned out to not be compatible with the web. BUG=None LOG=Y R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22497

Patch Set 1 #

Patch Set 2 : Update flag description for harmony #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -164 lines) Patch
M src/arm/full-codegen-arm.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 2 chunks +1 line, -8 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +1 line, -8 lines 0 comments Download
M src/flag-definitions.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 2 chunks +2 lines, -9 lines 0 comments Download
D test/mjsunit/harmony/typeof.js View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
arv (Not doing code reviews)
PTAL
6 years, 5 months ago (2014-07-18 14:51:59 UTC) #1
arv (Not doing code reviews)
Update flag description for harmony
6 years, 5 months ago (2014-07-18 16:49:06 UTC) #2
rossberg
lgtm
6 years, 5 months ago (2014-07-21 09:51:56 UTC) #3
rossberg
6 years, 5 months ago (2014-07-21 10:21:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22497 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698