Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 408443004: Web Animations: Remove confusing interpolation subdirectory. (Closed)

Created:
6 years, 5 months ago by shans
Modified:
6 years, 5 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-reviews-css, rune+blink, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, rwlbuis, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Web Animations: Remove confusing interpolation subdirectory. The current distribution of files doesn't make sense. I have an idea for a better split that I'd like to try, but that's speculative, so first we should reset to a good state. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -858 lines) Patch
M Source/core/animation/Animation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationStackTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/animation/DefaultStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/animation/DeferredLegacyStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/animation/DeferredLegacyStyleInterpolation.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/animation/DeferredLegacyStyleInterpolationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InertAnimation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InterpolableValueTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/animation/Interpolation.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/animation/Interpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InterpolationEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/KeyframeEffectModelTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/animation/LegacyStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/animation/LengthStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/animation/LengthStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/animation/LengthStyleInterpolationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/SampledEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/SampledEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + Source/core/animation/StyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableValueKeyframe.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/animation/interpolation/DefaultStyleInterpolation.h View 1 chunk +0 lines, -46 lines 0 comments Download
D Source/core/animation/interpolation/DeferredLegacyStyleInterpolation.h View 1 chunk +0 lines, -53 lines 0 comments Download
D Source/core/animation/interpolation/DeferredLegacyStyleInterpolation.cpp View 1 chunk +0 lines, -152 lines 0 comments Download
D Source/core/animation/interpolation/DeferredLegacyStyleInterpolationTest.cpp View 1 chunk +0 lines, -94 lines 0 comments Download
D Source/core/animation/interpolation/Interpolation.h View 1 chunk +0 lines, -47 lines 0 comments Download
D Source/core/animation/interpolation/Interpolation.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
D Source/core/animation/interpolation/LegacyStyleInterpolation.h View 1 chunk +0 lines, -47 lines 0 comments Download
D Source/core/animation/interpolation/LengthStyleInterpolation.h View 1 chunk +0 lines, -42 lines 0 comments Download
D Source/core/animation/interpolation/LengthStyleInterpolation.cpp View 1 chunk +0 lines, -109 lines 0 comments Download
D Source/core/animation/interpolation/LengthStyleInterpolationTest.cpp View 1 chunk +0 lines, -119 lines 0 comments Download
D Source/core/animation/interpolation/StyleInterpolation.h View 1 chunk +0 lines, -48 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
shans
The current distribution of files doesn't make sense. I have an idea for a better ...
6 years, 5 months ago (2014-07-21 00:41:56 UTC) #1
alancutter (OOO until 2018)
lgtm after talking about the future restructuring plans with shans.
6 years, 5 months ago (2014-07-21 01:12:36 UTC) #2
dstockwell
lgtm
6 years, 5 months ago (2014-07-21 01:34:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shans@chromium.org/408443004/1
6 years, 5 months ago (2014-07-21 01:35:53 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-21 02:37:24 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 03:04:00 UTC) #6
Message was sent while issue was closed.
Change committed as 178534

Powered by Google App Engine
This is Rietveld 408576698