Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 408443002: Remove TRACE_EVENT_PHASE_INSTANT_WITH_SCOPE (Closed)

Created:
6 years, 5 months ago by yurys
Modified:
6 years, 5 months ago
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-events_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove TRACE_EVENT_PHASE_INSTANT_WITH_SCOPE This change unifies instant event phase name between Chromium and Blink. Now it is 'I' in both projects. BUG=None R=loislo@chromium.org, pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178641

Patch Set 1 #

Patch Set 2 : Fixed tests #

Patch Set 3 : Fixed one more test #

Patch Set 4 : Use 'I' for phase id to match Chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M Source/core/inspector/TraceEventDispatcher.cpp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/TraceEvent.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
yurys
6 years, 5 months ago (2014-07-18 13:59:10 UTC) #1
yurys
6 years, 5 months ago (2014-07-21 05:39:22 UTC) #2
dsinclair
So, does this one need to change to "I" since the chrome side just switched?
6 years, 5 months ago (2014-07-21 14:31:34 UTC) #3
yurys
On 2014/07/21 14:31:34, dsinclair wrote: > So, does this one need to change to "I" ...
6 years, 5 months ago (2014-07-21 14:41:58 UTC) #4
loislo
lgtm
6 years, 5 months ago (2014-07-22 07:24:53 UTC) #5
yurys
@pfeldman: need OWNERS stamp for Source/platform/ changes.
6 years, 5 months ago (2014-07-22 07:33:09 UTC) #6
pfeldman
lgtm
6 years, 5 months ago (2014-07-22 08:25:37 UTC) #7
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 5 months ago (2014-07-22 09:03:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/408443002/60001
6 years, 5 months ago (2014-07-22 09:04:18 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-22 10:06:28 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 10:57:47 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/18211)
6 years, 5 months ago (2014-07-22 10:57:49 UTC) #12
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 5 months ago (2014-07-22 11:22:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/408443002/60001
6 years, 5 months ago (2014-07-22 11:23:56 UTC) #14
yurys
6 years, 5 months ago (2014-07-22 12:01:23 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 manually as r178641 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698