Added options to save pages into BMP and EMF on Windows.

Added options to save pages into BMP and EMF on Windows.

BUG=179413
R=bo_xu@foxitsoftware.com

Committed: https://pdfium.googlesource.com/pdfium/+/9e0177a

[Bo Xu, 2014-07-22 23:13:48]

https://codereview.chromium.org/408403002/diff/60001/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/408403002/diff/60001/samples/pdfium_test.cc#n...
samples/pdfium_test.cc:324: DeleteEnhMetaFile(CloseEnhMetaFile(dc));
It seems we won't do anything when (format == OUTPUT_BMP), what about the
following to eliminate the FPDF_RenderPage call when format==OUTPUT_BMP

if (format == OUTPUT_EMF)
{
    HDC dc = CreatePageMetafile(name, i, width, height);
    FPDF_RenderPage(dc, page, 0, 0, width, height,
                    0, FPDF_ANNOT | FPDF_PRINTING | FPDF_NO_CATCH);
    DeleteEnhMetaFile(CloseEnhMetaFile(dc));
}

Also, I checked the output emf file, it is not exactly the same as the bmp,
corner is cropped.

[Vitaly Buka (NO REVIEWS), 2014-07-22 23:24:46]

https://codereview.chromium.org/408403002/diff/60001/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/408403002/diff/60001/samples/pdfium_test.cc#n...
samples/pdfium_test.cc:324: DeleteEnhMetaFile(CloseEnhMetaFile(dc));
On 2014/07/22 23:13:48, Bo Xu wrote:
> It seems we won't do anything when (format == OUTPUT_BMP), what about the
> following to eliminate the FPDF_RenderPage call when format==OUTPUT_BMP

Actually idea was to call that code just like it done for images.
if no switches are there, it still renders bitmap.

But I can change as you suggesting.




> 
> if (format == OUTPUT_EMF)
> {
>     HDC dc = CreatePageMetafile(name, i, width, height);
>     FPDF_RenderPage(dc, page, 0, 0, width, height,
>                     0, FPDF_ANNOT | FPDF_PRINTING | FPDF_NO_CATCH);
>     DeleteEnhMetaFile(CloseEnhMetaFile(dc));
> }
> 
> Also, I checked the output emf file, it is not exactly the same as the bmp,
> corner is cropped.
> 

How exactly this cropped?
This could be cropped to match your screen resolution
what do you see if you call FPDF_RenderPage(dc, page, 0, 0, 500, 500, ?

[Vitaly Buka (NO REVIEWS), 2014-07-23 00:03:36]

On 2014/07/22 23:24:46, Vitaly Buka wrote:
> https://codereview.chromium.org/408403002/diff/60001/samples/pdfium_test.cc
> File samples/pdfium_test.cc (right):
> 
>
https://codereview.chromium.org/408403002/diff/60001/samples/pdfium_test.cc#n...
> samples/pdfium_test.cc:324: DeleteEnhMetaFile(CloseEnhMetaFile(dc));
> On 2014/07/22 23:13:48, Bo Xu wrote:
> > It seems we won't do anything when (format == OUTPUT_BMP), what about the
> > following to eliminate the FPDF_RenderPage call when format==OUTPUT_BMP
> 
> Actually idea was to call that code just like it done for images.
> if no switches are there, it still renders bitmap.
> 
> But I can change as you suggesting.
> 
> 
> 
> 
> > 
> > if (format == OUTPUT_EMF)
> > {
> >     HDC dc = CreatePageMetafile(name, i, width, height);
> >     FPDF_RenderPage(dc, page, 0, 0, width, height,
> >                     0, FPDF_ANNOT | FPDF_PRINTING | FPDF_NO_CATCH);
> >     DeleteEnhMetaFile(CloseEnhMetaFile(dc));
> > }
> > 
> > Also, I checked the output emf file, it is not exactly the same as the bmp,
> > corner is cropped.
> > 
> 
> How exactly this cropped?
> This could be cropped to match your screen resolution
> what do you see if you call FPDF_RenderPage(dc, page, 0, 0, 500, 500, ?

please take another look

[Vitaly Buka (NO REVIEWS), 2014-07-23 00:09:51]

On 2014/07/23 00:03:36, Vitaly Buka wrote:
> On 2014/07/22 23:24:46, Vitaly Buka wrote:
> > https://codereview.chromium.org/408403002/diff/60001/samples/pdfium_test.cc
> > File samples/pdfium_test.cc (right):
> > 
> >
>
https://codereview.chromium.org/408403002/diff/60001/samples/pdfium_test.cc#n...
> > samples/pdfium_test.cc:324: DeleteEnhMetaFile(CloseEnhMetaFile(dc));
> > On 2014/07/22 23:13:48, Bo Xu wrote:
> > > It seems we won't do anything when (format == OUTPUT_BMP), what about the
> > > following to eliminate the FPDF_RenderPage call when format==OUTPUT_BMP
> > 
> > Actually idea was to call that code just like it done for images.
> > if no switches are there, it still renders bitmap.
> > 
> > But I can change as you suggesting.
> > 
> > 
> > 
> > 
> > > 
> > > if (format == OUTPUT_EMF)
> > > {
> > >     HDC dc = CreatePageMetafile(name, i, width, height);
> > >     FPDF_RenderPage(dc, page, 0, 0, width, height,
> > >                     0, FPDF_ANNOT | FPDF_PRINTING | FPDF_NO_CATCH);
> > >     DeleteEnhMetaFile(CloseEnhMetaFile(dc));
> > > }
> > > 
> > > Also, I checked the output emf file, it is not exactly the same as the
bmp,
> > > corner is cropped.
> > > 
> > 
> > How exactly this cropped?
> > This could be cropped to match your screen resolution
> > what do you see if you call FPDF_RenderPage(dc, page, 0, 0, 500, 500, ?
> 
> please take another look

just updated again, probably scaling is not nessesary

[Bo Xu, 2014-07-23 00:31:47]

https://codereview.chromium.org/408403002/diff/170001/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/408403002/diff/170001/samples/pdfium_test.cc#...
samples/pdfium_test.cc:131: HPEN pen = CreatePen(PS_DASH, 5, RGB(255, 0, 0));
Not sure if we want to mark the boundary here, or just make the emf file the
same as the original pdf rendering?

I imagine the emf could be sent to the printer and printed the same as a bitmap?

[Vitaly Buka (NO REVIEWS), 2014-07-23 00:35:42]

https://codereview.chromium.org/408403002/diff/170001/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/408403002/diff/170001/samples/pdfium_test.cc#...
samples/pdfium_test.cc:131: HPEN pen = CreatePen(PS_DASH, 5, RGB(255, 0, 0));
I had impression is just test application and no one is going to use this
output.

It's hard to see EMF boundaries, first approach was just put them in file name,
but this one should be more convenient.

On 2014/07/23 00:31:47, Bo Xu wrote:
> Not sure if we want to mark the boundary here, or just make the emf file the
> same as the original pdf rendering?
> 
> I imagine the emf could be sent to the printer and printed the same as a
bitmap?

[Bo Xu, 2014-07-23 01:13:17]

lgtm

[Vitaly Buka (NO REVIEWS), 2014-07-23 01:15:48]

Committed patchset #8 manually as r9e0177a (presubmit successful).