Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4671)

Unified Diff: build/common.gypi

Issue 408393002: Enable ARM/linux cross compile to use clang. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 79d3f986192bbaf837dd0ca5cf28c76735f82604..00323f5cc7b5687c4b35910da8dcc56592ec0c70 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3703,19 +3703,39 @@
['target_arch=="arm"', {
'target_conditions': [
['_toolset=="target"', {
- 'cflags_cc': [
- # The codesourcery arm-2009q3 toolchain warns at that the ABI
- # has changed whenever it encounters a varargs function. This
- # silences those warnings, as they are not helpful and
- # clutter legitimate warnings.
- '-Wno-abi',
- ],
'conditions': [
+ ['clang==0', {
+ 'cflags_cc': [
+ # The codesourcery arm-2009q3 toolchain warns at that the ABI
+ # has changed whenever it encounters a varargs function. This
+ # silences those warnings, as they are not helpful and
+ # clutter legitimate warnings.
+ '-Wno-abi',
+ ],
+ }],
+ ['clang==1 and arm_arch!=""', {
+ 'cflags': [
+ '-target arm-linux-gnueabihf',
+ # TODO(sbc): Remove this once the warning in libvpx is fixed:
+ # https://code.google.com/p/webm/issues/detail?id=829
+ '-Wno-absolute-value',
Nico 2014/08/08 15:28:44 nit: Normally, this should go into libvpx.gyp inst
+ ],
+ 'ldflags': [
+ '-target arm-linux-gnueabihf',
+ ],
+ }],
['arm_arch!=""', {
'cflags': [
'-march=<(arm_arch)',
],
}],
+ ['clang==1', {
+ 'cflags': [
+ # We need to disable clang's builtin assember as it can't
+ # handle a several of asm files.
Nico 2014/08/08 15:28:44 Include link to http://crbug.com/124610 (the bug t
+ '-no-integrated-as',
+ ],
+ }],
['arm_tune!=""', {
'cflags': [
'-mtune=<(arm_tune)',
« no previous file with comments | « no previous file | build/linux/install-arm-sysroot.py » ('j') | chrome/test/data/nacl/nameservice/pm_nameservice_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698