Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 408373002: Adds intrinsics for Float64Array [] and []=. (Closed)

Created:
6 years, 5 months ago by zra
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, regis
Visibility:
Public.

Description

Adds intrinsics for Float64Array [] and []=. Improves performance in unoptimized code. R=regis@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=38483

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+732 lines, -327 lines) Patch
M runtime/vm/assembler_arm.h View 1 2 chunks +18 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 2 chunks +78 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 1 chunk +41 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 1 chunk +50 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 1 chunk +41 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 4 chunks +18 lines, -103 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 2 chunks +12 lines, -54 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 2 chunks +10 lines, -58 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 3 chunks +12 lines, -54 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 2 chunks +10 lines, -58 lines 0 comments Download
M runtime/vm/intrinsifier.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 chunk +69 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 chunk +67 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zra
6 years, 5 months ago (2014-07-22 20:53:35 UTC) #1
regis
LGTM
6 years, 5 months ago (2014-07-22 22:08:06 UTC) #2
srdjan
lgtm
6 years, 5 months ago (2014-07-22 22:48:12 UTC) #3
zra
6 years, 5 months ago (2014-07-22 23:16:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r38483 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698