Issue 40833003: Make the last change hook also generate C header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 40833003: Make the last change hook also generate C header files. (Closed)

Created:
7 years, 2 months ago by brettw

Modified:
7 years, 1 month ago

Reviewers:
viettrungluu

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Make the last change hook also generate C header files.

Total comments: 4

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -9 lines)			Patch
M	.gitignore	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	DEPS	View		2 chunks	+6 lines, -2 lines	2 comments	Download
M	build/util/lastchange.py	View	1	3 chunks	+58 lines, -7 lines	2 comments	Download

Total messages: 3 (0 generated)

brettw

I want to include this in the GN --version command so figured we should have ...

7 years, 2 months ago (2013-10-24 20:24:15 UTC) #1

viettrungluu

LGTM w/nits and a question, though I don't really know what I'm looking at that ...

7 years, 2 months ago (2013-10-24 21:06:40 UTC) #2

brettw

7 years, 1 month ago (2013-10-25 23:06:13 UTC) #3

Closed in favor of https://codereview.chromium.org/46003002/