Issue 408293002: Support for :enabled selector on Anchor & Area elements

Issue 408293002: Support for :enabled selector on Anchor & Area elements (Closed)

Created:
6 years, 5 months ago by abinader

Modified:
6 years, 4 months ago

Reviewers:
esprehn, dglazkov, darktears, Julien - ping for review

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Support for :enabled selector on Anchor & Area elements Updates the PseudoEnabled selector checker to check for Anchor & Area elements with a link. Reverts ef7563d45ca529252c4caa612dece0ddb1dcfc1d which removed relevant Shadow DOM tests. Spec: http://html.spec.whatwg.org/#selector-enabled BUG=393105 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179427

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated layout tests with fixes from esprehn #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -55 lines)			Patch
A +	LayoutTests/fast/dom/shadow/pseudoclass-update-enabled-anchor.html	View	1	1 chunk	+2 lines, -16 lines	0 comments	Download
A +	LayoutTests/fast/dom/shadow/pseudoclass-update-enabled-anchor-expected.html	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download
A +	LayoutTests/fast/dom/shadow/pseudoclass-update-enabled-area.html	View	1	3 chunks	+2 lines, -16 lines	0 comments	Download
A +	LayoutTests/fast/dom/shadow/pseudoclass-update-enabled-area-expected.html	View	1	2 chunks	+0 lines, -13 lines	0 comments	Download
M	Source/core/css/SelectorChecker.cpp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Julien - ping for review

I am not comfortable with this code, Dimitri or Alexis should comment.

6 years, 5 months ago (2014-07-23 02:36:49 UTC) #1

abinader

On 2014/07/23 02:36:49, Julien Chaffraix - PST wrote: > I am not comfortable with this ...

6 years, 4 months ago (2014-08-01 14:14:23 UTC) #2

esprehn

lgtm with a few nits. https://codereview.chromium.org/408293002/diff/1/LayoutTests/fast/dom/shadow/pseudoclass-update-enabled-anchor-expected.html File LayoutTests/fast/dom/shadow/pseudoclass-update-enabled-anchor-expected.html (right): https://codereview.chromium.org/408293002/diff/1/LayoutTests/fast/dom/shadow/pseudoclass-update-enabled-anchor-expected.html#newcode4 LayoutTests/fast/dom/shadow/pseudoclass-update-enabled-anchor-expected.html:4: <body> Leave out body ...

6 years, 4 months ago (2014-08-01 17:48:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bruno.d@partner.samsung.com/408293002/20001

6 years, 4 months ago (2014-08-01 21:43:26 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...

6 years, 4 months ago (2014-08-01 22:47:04 UTC) #6

abinader

6 years, 2 months ago (2014-09-26 18:43:39 UTC) #8

Message was sent while issue was closed.

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/610683002/ by bruno.d@partner.samsung.com.

The reason for reverting is: HTML spec has been modified [1] to disable support
for :enabled CSS selector on Anchor, Area & Link elements, after discussion on
W3C Bugzilla [2].

[1] https://html5.org/r/8818
[2] https://www.w3.org/Bugs/Public/show_bug.cgi?id=26622.

Expand Messages | Collapse Messages