Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: Source/core/rendering/RenderObject.h

Issue 408273003: Reset m_didTransformToRootUpdate flag during invalidationTreeIfNeeded (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Based on https://codereview.chromium.org/389573008/ Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderObject.h
diff --git a/Source/core/rendering/RenderObject.h b/Source/core/rendering/RenderObject.h
index 7c9717008de3519e17991f67362e203be307240d..f17b4c0ed3f620f0be8aef9322c0205824d240a9 100644
--- a/Source/core/rendering/RenderObject.h
+++ b/Source/core/rendering/RenderObject.h
@@ -1047,7 +1047,7 @@ public:
bool onlyNeededPositionedMovementLayout() const { return m_bitfields.onlyNeededPositionedMovementLayout(); }
void setOnlyNeededPositionedMovementLayout(bool b) { m_bitfields.setOnlyNeededPositionedMovementLayout(b); }
- void clearPaintInvalidationState();
+ virtual void clearPaintInvalidationState();
// layoutDidGetCalled indicates whether this render object was re-laid-out
// since the last call to setLayoutDidGetCalled(false) on this object.
@@ -1135,6 +1135,14 @@ protected:
void incrementallyInvalidatePaint(const RenderLayerModelObject& paintInvalidationContainer, const LayoutRect& oldBounds, const LayoutRect& newBounds);
void fullyInvalidatePaint(const RenderLayerModelObject& paintInvalidationContainer, InvalidationReason, const LayoutRect& oldBounds, const LayoutRect& newBounds);
+#if ENABLE(ASSERT)
+ virtual bool paintInvalidationStateIsDirty() const
+ {
+ return layoutDidGetCalled() || shouldDoFullPaintInvalidation() || shouldDoFullPaintInvalidationIfSelfPaintingLayer()
+ || onlyNeededPositionedMovementLayout() || neededLayoutBecauseOfChildren() || mayNeedPaintInvalidation();
+ }
+#endif
+
private:
const RenderLayerModelObject* enclosingCompositedContainer() const;
@@ -1155,12 +1163,6 @@ private:
#if ENABLE(ASSERT)
void checkBlockPositionedObjectsNeedLayout();
-
- bool paintInvalidationStateIsDirty() const
- {
- return layoutDidGetCalled() || shouldDoFullPaintInvalidation() || shouldDoFullPaintInvalidationIfSelfPaintingLayer()
- || onlyNeededPositionedMovementLayout() || neededLayoutBecauseOfChildren() || mayNeedPaintInvalidation();
- }
#endif
const char* invalidationReasonToString(InvalidationReason) const;

Powered by Google App Engine
This is Rietveld 408576698