Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 408193002: Move function prototype handling into a special handler rather than IC (Closed)

Created:
6 years, 5 months ago by Toon Verwaest
Modified:
6 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Move function prototype handling into a special handler rather than IC Adjust hydrogen handling of function.prototype to be based on map feedback. Handle non-instance prototype loading using an IC rather than in the hydrogen instruction. In the future, remove the special instruction and replace by multiple hydrogen instructions. BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22526

Patch Set 1 #

Patch Set 2 : Don't ensure that the IC state is monomorphic, but rather that the stubcache only contains handlers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -145 lines) Patch
M src/arm/lithium-codegen-arm.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M src/ast.h View 5 chunks +2 lines, -9 lines 0 comments Download
M src/code-stubs.h View 1 1 chunk +14 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 6 chunks +14 lines, -11 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M src/ic.cc View 2 chunks +10 lines, -25 lines 0 comments Download
M src/stub-cache.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M src/type-info.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/type-info.cc View 2 chunks +5 lines, -19 lines 0 comments Download
M src/typing.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 5 months ago (2014-07-22 12:57:08 UTC) #1
mvstanton
lgtm
6 years, 5 months ago (2014-07-22 13:14:37 UTC) #2
Toon Verwaest
6 years, 5 months ago (2014-07-22 14:28:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22526 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698