Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 408163002: Cleanup: use base::StringPrintf instead of snprintf in WebTestProxy. (Closed)

Created:
6 years, 5 months ago by dcheng
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cleanup: use base::StringPrintf instead of snprintf in WebTestProxy. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284810

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -26 lines) Patch
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 6 chunks +14 lines, -26 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
dcheng
I think this is more readable and "obviously" safer, but curious what you think.
6 years, 5 months ago (2014-07-22 06:38:01 UTC) #1
jochen (gone - plz use gerrit)
On 2014/07/22 at 06:38:01, dcheng wrote: > I think this is more readable and "obviously" ...
6 years, 5 months ago (2014-07-22 07:28:24 UTC) #2
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 5 months ago (2014-07-22 07:29:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/408163002/1
6 years, 5 months ago (2014-07-22 07:30:31 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 11:16:21 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 12:26:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/41511)
6 years, 5 months ago (2014-07-22 12:26:02 UTC) #7
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 5 months ago (2014-07-22 18:19:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/408163002/1
6 years, 5 months ago (2014-07-22 18:21:45 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 18:32:39 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 18:42:08 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/41658)
6 years, 5 months ago (2014-07-22 18:42:09 UTC) #12
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 5 months ago (2014-07-22 21:09:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/408163002/20001
6 years, 5 months ago (2014-07-22 21:11:43 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 23:43:35 UTC) #15
Message was sent while issue was closed. 
Change committed as 284810

Powered by Google App Engine
This is Rietveld 408576698