Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Issue 408153003: Simplify RunTaskOnThread (Closed)

Created:
6 years, 5 months ago by hashimoto
Modified:
6 years, 5 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, tfarina, nhiroki, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Simplify RunTaskOnThread RunTaskOnThread has been running tasks synchronously if the task runner belongs to the current thread. This behavior was necessary when it was allowed to access drive::FileSystem from both UI and IO threads. But now, no one needs this behavior and every user uses this method to post tasks to the specified runner. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284851

Patch Set 1 #

Patch Set 2 : Fix FileCacheTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M chrome/browser/chromeos/drive/file_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache_unittest.cc View 1 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/fileapi/async_file_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/drive/task_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
M google_apis/drive/task_util.cc View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
hashimoto
6 years, 5 months ago (2014-07-22 07:05:30 UTC) #1
kinaba
lgtm
6 years, 5 months ago (2014-07-22 07:10:17 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 5 months ago (2014-07-22 07:17:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/408153003/1
6 years, 5 months ago (2014-07-22 07:19:35 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 08:55:58 UTC) #5
hashimoto
Fixed FileCacheTest by adding base::RunLoop().RunUntilIdle();
6 years, 5 months ago (2014-07-22 09:10:23 UTC) #6
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 5 months ago (2014-07-22 09:10:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/408153003/20001
6 years, 5 months ago (2014-07-22 09:11:11 UTC) #8
kinaba
On 2014/07/22 09:10:23, hashimoto wrote: > Fixed FileCacheTest by adding base::RunLoop().RunUntilIdle(); still lgtm
6 years, 5 months ago (2014-07-22 09:11:30 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 11:07:21 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 12:23:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/41507)
6 years, 5 months ago (2014-07-22 12:23:34 UTC) #12
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 5 months ago (2014-07-23 03:06:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/408153003/20001
6 years, 5 months ago (2014-07-23 03:07:12 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 06:06:14 UTC) #15
Message was sent while issue was closed.
Change committed as 284851

Powered by Google App Engine
This is Rietveld 408576698