Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: chrome/browser/chromeos/drive/file_system/operation_delegate.h

Issue 408143014: Rename OperationObserver to OperationDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/drive/file_system/operation_delegate.h
diff --git a/chrome/browser/chromeos/drive/file_system/operation_observer.h b/chrome/browser/chromeos/drive/file_system/operation_delegate.h
similarity index 84%
rename from chrome/browser/chromeos/drive/file_system/operation_observer.h
rename to chrome/browser/chromeos/drive/file_system/operation_delegate.h
index ffd378c994e0110983866c23f871e32f41127ad9..b35030711715f588ac0ba780d885f4c086867e0c 100644
--- a/chrome/browser/chromeos/drive/file_system/operation_observer.h
+++ b/chrome/browser/chromeos/drive/file_system/operation_delegate.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_CHROMEOS_DRIVE_FILE_SYSTEM_OPERATION_OBSERVER_H_
-#define CHROME_BROWSER_CHROMEOS_DRIVE_FILE_SYSTEM_OPERATION_OBSERVER_H_
+#ifndef CHROME_BROWSER_CHROMEOS_DRIVE_FILE_SYSTEM_OPERATION_DELEGATE_H_
+#define CHROME_BROWSER_CHROMEOS_DRIVE_FILE_SYSTEM_OPERATION_DELEGATE_H_
#include "chrome/browser/chromeos/drive/file_errors.h"
@@ -28,13 +28,12 @@ enum DriveSyncErrorType {
};
// Passes notifications from Drive operations back to the file system.
-// TODO(hashimoto): Give this class a more appropriate name.
-class OperationObserver {
+class OperationDelegate {
public:
// Sent when a content of a directory has been changed.
// |directory_path| is a virtual directory path representing the
// changed directory.
- virtual void OnFileChangedByOperation(const FileChange& changed_files) = 0;
+ virtual void OnFileChangedByOperation(const FileChange& changed_files) {}
// Sent when an entry is updated and sync is needed.
virtual void OnEntryUpdatedByOperation(const std::string& local_id) {}
@@ -53,4 +52,4 @@ class OperationObserver {
} // namespace file_system
} // namespace drive
-#endif // CHROME_BROWSER_CHROMEOS_DRIVE_FILE_SYSTEM_OPERATION_OBSERVER_H_
+#endif // CHROME_BROWSER_CHROMEOS_DRIVE_FILE_SYSTEM_OPERATION_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698