Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 408143014: Rename OperationObserver to OperationDelegate (Closed)

Created:
6 years, 5 months ago by hashimoto
Modified:
6 years, 5 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tim+watch_chromium.org, nkostylev+watch_chromium.org, zea+watch_chromium.org, tzik, tfarina, haitaol+watch_chromium.org, nhiroki, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Rename OperationObserver to OperationDelegate This class is doing more than just an observer. Add a default implmentation of OperationDelegate::OnFileChangedByOperation() to remove DummyOperationObserver in sync_client_unittest.cc BUG=None TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285117

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -362 lines) Patch
M chrome/browser/chromeos/drive/file_system.h View 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.cc View 8 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation_unittest.cc View 12 chunks +26 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_directory_operation.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_directory_operation.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_directory_operation_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_file_operation.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_file_operation.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_file_operation_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation_unittest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation_unittest.cc View 3 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/move_operation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/move_operation.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/move_operation_unittest.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/open_file_operation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/open_file_operation.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/open_file_operation_unittest.cc View 8 chunks +11 lines, -11 lines 0 comments Download
A + chrome/browser/chromeos/drive/file_system/operation_delegate.h View 3 chunks +5 lines, -6 lines 0 comments Download
A + chrome/browser/chromeos/drive/file_system/operation_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/drive/file_system/operation_observer.h View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/chromeos/drive/file_system/operation_observer.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/operation_test_base.h View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/operation_test_base.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/remove_operation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/remove_operation.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/remove_operation_unittest.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/touch_operation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/touch_operation.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/touch_operation_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/truncate_operation.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/truncate_operation.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/truncate_operation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_revert_performer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_revert_performer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_revert_performer_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/remove_performer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/remove_performer.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/remove_performer_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client_unittest.cc View 6 chunks +5 lines, -11 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hashimoto
6 years, 5 months ago (2014-07-23 08:05:24 UTC) #1
kinaba
lgtm
6 years, 5 months ago (2014-07-23 08:30:28 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 5 months ago (2014-07-23 10:13:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/408143014/20001
6 years, 5 months ago (2014-07-23 10:14:45 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 13:33:47 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 14:01:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/42043)
6 years, 5 months ago (2014-07-23 14:01:12 UTC) #7
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 5 months ago (2014-07-24 00:31:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/408143014/20001
6 years, 5 months ago (2014-07-24 00:33:14 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 02:33:21 UTC) #10
Message was sent while issue was closed.
Change committed as 285117

Powered by Google App Engine
This is Rietveld 408576698