Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 408143013: Remove unused ServiceWorkerDispatcher instance (Closed)

Created:
6 years, 5 months ago by kouhei (in TOK)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Remove unused ServiceWorkerDispatcher instance The instance |ChildThread::service_worker_dispatcher_| is never used. Removing. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M content/child/child_thread.h View 3 chunks +0 lines, -7 lines 0 comments Download
M content/child/child_thread.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kouhei (in TOK)
nhiroki: A little clean up CL. PTAL.
6 years, 5 months ago (2014-07-23 06:03:39 UTC) #1
nhiroki
LGTM, thanks!
6 years, 5 months ago (2014-07-23 08:40:54 UTC) #2
kouhei (in TOK)
jochen: Would you take a look?
6 years, 5 months ago (2014-07-23 09:38:21 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-23 09:46:16 UTC) #4
kouhei (in TOK)
Thanks for review!
6 years, 5 months ago (2014-07-23 09:49:03 UTC) #5
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 5 months ago (2014-07-23 09:49:04 UTC) #6
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 5 months ago (2014-07-23 09:49:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/408143013/1
6 years, 5 months ago (2014-07-23 09:49:24 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 11:19:29 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 11:23:05 UTC) #10
Message was sent while issue was closed.
Change committed as 284904

Powered by Google App Engine
This is Rietveld 408576698