Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 408133002: Fix remaining CXX cross-compilation builds in Makefile. (Closed)

Created:
6 years, 5 months ago by paul.l...
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix remaining CXX cross-compilation builds in Makefile. r22509 fixed arm and mips (big-endian) cross-compilation builds. It did not fix mipsel, mips64el, or arm64 builds, since the toolchain prefix did not match the v8_target_arch. For mips, the toolchain is typically named mips-linux-gnu-g++, but it can compile for mipsel or mips64el via flags. (There can also be mipsel-linux-gnu-g++ toolchains, and this patch will work for mipsel build in that case). For arm64, the toolchains seem to be named aarch64-linux-gnu-g++. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22531

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M Makefile View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
paul.l...
PTAL. Tests fine for me, but please check the arm64 side, I made have made ...
6 years, 5 months ago (2014-07-22 04:32:01 UTC) #1
Jakob Kummerow
LGTM, thanks! One comment for the record: this approach might get confused by "arm" vs. ...
6 years, 5 months ago (2014-07-22 08:53:29 UTC) #2
rmcilroy
On 2014/07/22 08:53:29, Jakob wrote: > LGTM, thanks! > > One comment for the record: ...
6 years, 5 months ago (2014-07-22 09:10:58 UTC) #3
paul.l...
6 years, 5 months ago (2014-07-22 15:29:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r22531 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698