Issue 408113003: Only build relocation packer for Arm and Arm64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 408113003: Only build relocation packer for Arm and Arm64 (Closed)

Created:
6 years, 5 months ago by Anton

Modified:
6 years, 5 months ago

Reviewers:
anton1, rmcilroy, simonb (inactive)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Only build relocation packer for Arm and Arm64. Fix x64 build. BUG=346626

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	build/all.gyp	View		2 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 7 (0 generated)

Anton

The build for x64 was broken by: https://codereview.chromium.org/404553003 Both the CL description and the preprocessor ...

6 years, 5 months ago (2014-07-22 09:46:33 UTC) #1

simonb (inactive)

On 2014/07/22 09:58:32, simonb wrote: > lgtm Oh, and thanks for fixing!

6 years, 5 months ago (2014-07-22 09:58:55 UTC) #3

rmcilroy

On 2014/07/22 09:58:55, simonb wrote: > On 2014/07/22 09:58:32, simonb wrote: > > lgtm > ...

6 years, 5 months ago (2014-07-22 12:35:40 UTC) #4

anton1

6 years, 5 months ago (2014-07-22 12:45:41 UTC) #7

On 2014/07/22 12:37:22, anton1 wrote:
> The CQ bit was unchecked by mailto:anton@google.com

Closing this one since the duplicate landed.