Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1247)

Issue 408103004: Mac: Fix bad framerate when capturing tab (Closed)

Created:
6 years, 5 months ago by ccameron
Modified:
6 years, 5 months ago
Reviewers:
miu
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mac: Fix bad framerate when capturing tab The fix for this issue, namely, that we must draw contents manually and immediately when a window is occluded because Cocoa will not draw them for us, was not ported to the browser compositor. Plumb this explicitly through a ShouldAckImmediately callback for CompositingIOSurfaceLayerClient and BrowserCompositorViewMacClient. Also check for vsync disabling in the ShouldAckImmediately instead of running it (unnecessarily) through CompositingIOSurfaceContextMac. BUG=393390, 350410 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284856

Patch Set 1 #

Messages

Total messages: 11 (0 generated)
ccameron
Sorry this took so long to get to!
6 years, 5 months ago (2014-07-22 02:20:37 UTC) #1
miu
lgtm, thanks! :)
6 years, 5 months ago (2014-07-22 20:07:47 UTC) #2
ccameron
Thanks!
6 years, 5 months ago (2014-07-22 20:25:54 UTC) #3
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 5 months ago (2014-07-22 20:25:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/408103004/1
6 years, 5 months ago (2014-07-22 20:28:08 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-22 23:51:09 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 01:42:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31144)
6 years, 5 months ago (2014-07-23 01:42:52 UTC) #8
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 5 months ago (2014-07-23 01:43:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/408103004/1
6 years, 5 months ago (2014-07-23 01:44:36 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 06:18:13 UTC) #11
Message was sent while issue was closed.
Change committed as 284856

Powered by Google App Engine
This is Rietveld 408576698