Added accessible name to bookmark_bar_instructions_view.

Added accessible name to bookmark_bar_instructions_view.
The state is now taken from the label with the instructions within the bookmark bar.
Now an empty bookmark bar's label is accessible.

BUG=395895
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285704

[evy, 2014-07-22 01:18:20]

Note that this is only a partial fix so far.
Chromevox thinks that the bookmark bar is a button, but I need to change it so
that it can read static text.

[evy, 2014-07-22 01:18:21]

Note that this is only a partial fix so far.
Chromevox thinks that the bookmark bar is a button, but I need to change it so
that it can read static text.

[David Tseng, 2014-07-22 04:50:49]

https://codereview.chromium.org/408103002/diff/1/chrome/browser/accessibility...
File chrome/browser/accessibility/accessibility_events.cc (left):

https://codereview.chromium.org/408103002/diff/1/chrome/browser/accessibility...
chrome/browser/accessibility/accessibility_events.cc:51: 
nit: not needed?

https://codereview.chromium.org/408103002/diff/1/chrome/browser/ui/views/book...
File chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc
(right):

https://codereview.chromium.org/408103002/diff/1/chrome/browser/ui/views/book...
chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc:103:
state->role = ui::AX_ROLE_BUTTON;
Can we get a TODO(evy) here that links to a bug explaining the issue?

[evy, 2014-07-22 05:00:38]

https://codereview.chromium.org/408103002/diff/1/chrome/browser/ui/views/book...
File chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc
(right):

https://codereview.chromium.org/408103002/diff/1/chrome/browser/ui/views/book...
chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc:103:
state->role = ui::AX_ROLE_BUTTON;
On 2014/07/22 04:50:49, David Tseng wrote:
> Can we get a TODO(evy) here that links to a bug explaining the issue?

I was hoping maybe we could do a fix tomorrow, but if it's going to take a while
I can add the TODO and submit this CL sooner.

thoughts?

[David Tseng, 2014-07-23 23:46:31]

lgtm

[evy, 2014-07-24 00:14:00]

+sky for OWNERS review on:
chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc
chrome/browser/ui/views/accessibility/accessibility_event_router_views.h
chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

[sky, 2014-07-24 16:51:14]

LGTM

[evy, 2014-07-25 16:35:11]

From what I understand about why we can't make tabs accessibility focusable, I
think it's okay to do it here.
It's technically not even needed if we make the change so the tabs are read, but
I think it makes sense.
I think Sky pointed out to me earlier that we would want to have a box around it
to visually show it was selected. Is this hard to do? If so, maybe I'll stick to
just the other fix for now.

[dmazzoni, 2014-07-25 16:48:30]

On 2014/07/25 16:35:11, evy wrote:
> I think Sky pointed out to me earlier that we would want to have a box around
it
> to visually show it was selected.

Not necessarily that hard depending on how we want the focus ring to look, but I
think that the extra keyboard shortcuts to make access to the tab strip actually
useful would make it warrant a separate change.

- Dominic

[evy, 2014-07-25 18:28:26]

On 2014/07/25 16:48:30, dmazzoni wrote:
> On 2014/07/25 16:35:11, evy wrote:
> > I think Sky pointed out to me earlier that we would want to have a box
around
> it
> > to visually show it was selected.
> 
> Not necessarily that hard depending on how we want the focus ring to look, but
I
> think that the extra keyboard shortcuts to make access to the tab strip
actually
> useful would make it warrant a separate change.
> 
> - Dominic

I removed the patch, I'll commit as it was

[evy, 2014-07-25 20:14:19]

The CQ bit was checked by evy@chromium.org

[commit-bot: I haz the power, 2014-07-25 20:15:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/evy@chromium.org/408103002/20001

[commit-bot: I haz the power, 2014-07-25 22:07:48]

Change committed as 285704