DescriptionRevert of Enforce clearing renderers' paint invalidation state (https://codereview.chromium.org/389573008/)
Reason for revert:
Causing consistent assertion failures on Mac. See e.g. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28dbg%29/builds/16532/steps/webkit_tests/logs/stdio . A sample stack:
STDERR: SHOULD NEVER BE REACHED
STDERR: ../../third_party/WebKit/Source/core/rendering/RenderObject.h(258) : void blink::RenderObject::assertRendererClearedPaintInvalidationState() const
STDERR: 1 0x99d08a7 blink::RenderObject::assertRendererClearedPaintInvalidationState() const
STDERR: 2 0x99bc4ee blink::RenderObject::assertSubtreeClearedPaintInvalidationState() const
STDERR: 3 0x99af007 blink::FrameView::invalidateTreeIfNeeded()
STDERR: 4 0x99b82ee blink::FrameView::invalidateTreeIfNeededRecursive()
STDERR: 5 0x99b710d blink::FrameView::updateLayoutAndStyleForPainting()
STDERR: 6 0x9d169f2 blink::PageAnimator::updateLayoutAndStyleForPainting(blink::LocalFrame*)
STDERR: 7 0x709b4fb blink::PageWidgetDelegate::layout(blink::Page*, blink::LocalFrame*)
STDERR: 8 0x720c8a4 blink::WebViewImpl::layout()
STDERR: 9 0xfc6ee content::EventSender::MouseMoveTo(gin::Arguments*)
STDERR: 10 0xf9be7 content::EventSenderBindings::MouseMoveTo(gin::Arguments*)
STDERR: 11 0x113572 base::internal::RunnableAdapter<void (content::EventSenderBindings::*)(gin::Arguments*)>::Run(content::EventSenderBindings*, gin::Arguments* const&)
STDERR: 12 0x1134af base::internal::InvokeHelper<false, void, base::internal::RunnableAdapter<void (content::EventSenderBindings::*)(gin::Arguments*)>, void ()(content::EventSenderBindings* const&, gin::Arguments* const&)>::MakeItSo(base::internal::RunnableAdapter<void (content::EventSenderBindings::*)(gin::Arguments*)>, content::EventSenderBindings* const&, gin::Arguments* const&)
STDERR: 13 0x11342b base::internal::Invoker<0, base::internal::BindState<base::internal::RunnableAdapter<void (content::EventSenderBindings::*)(gin::Arguments*)>, void ()(content::EventSenderBindings*, gin::Arguments*), void ()()>, void ()(content::EventSenderBindings*, gin::Arguments*)>::Run(base::internal::BindStateBase*, content::EventSenderBindings* const&, gin::Arguments* const&)
STDERR: 14 0x113c03 base::Callback<void ()(content::EventSenderBindings*, gin::Arguments*)>::Run(content::EventSenderBindings* const&, gin::Arguments* const&) const
STDERR: 15 0x113b5e gin::internal::Invoker<void, content::EventSenderBindings*, gin::Arguments*, void, void, void, void>::Go(gin::Arguments*, base::Callback<void ()(content::EventSenderBindings*, gin::Arguments*)> const&, content::EventSenderBindings* const&, gin::Arguments* const&)
STDERR: 16 0x113ab5 gin::internal::Dispatcher<void ()(content::EventSenderBindings*, gin::Arguments*)>::DispatchToCallback(v8::FunctionCallbackInfo<v8::Value> const&)
STDERR: 17 0x4f44b1e v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))
STDERR: 18 0x4f9c17e _ZN2v88internalL21Builtin_HandleApiCallEiPPNS0_6ObjectEPNS0_7IsolateE
STDERR: 19 0x4150a4b6
Original issue's description:
> Enforce clearing renderers' paint invalidation state
>
> The ASSERT checks that no flags cleared by clearPaintInvalidationState()
> is still set up after calling repaint-after-compositing-update.
>
> The ASSERT is skipped for SVG subtree as we have an optimization that
> skips them. We could reproduce the exact condition but it seems not
> very useful to do so.
>
> The change caught several bugs (yay!):
> - one in shouldCheckForPaintInvalidationAfterLayout()
> that made the ASSERT trip on fast/repaint/table-row.html.
> - one where setShouldDoFullPaintInvalidationAfterLayout didn't
> mark the containing block chain for invalidation.
>
> BUG=385169
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178089
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178569
TBR=dsinclair@chromium.org,falken@chromium.org,leviw@chromium.org,jchaffraix@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=385169
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178602
Patch Set 1 #
Created: 6 years, 5 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|