android tests: don't override DIR_MODULE

android tests: don't override DIR_MODULE

BUG=
R=brettw@chromium.org, nyquist@chromium.org, phajdan.jr@chromium.org, sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285096

[nyquist, 2014-07-22 19:46:42]

https://codereview.chromium.org/408063002/diff/20001/base/test/test_support_a...
File base/test/test_support_android.cc (left):

https://codereview.chromium.org/408063002/diff/20001/base/test/test_support_a...
base/test/test_support_android.cc:144: return
base::android::GetExternalStorageDirectory(result);
Did you look into the url fixer upper tests?

[tim (not reviewing), 2014-07-22 19:50:59]

On 2014/07/22 19:46:43, nyquist wrote:

Yeah, playing with them now as a matter of fact.  It looks like they should just
be using DIR_[GEN]_TEST_DATA.  Main issue is that is only available from
chrome/, but there's a todo there to move them (presumably to base).  I can move
DIR_GEN_TEST_DATA and use that, or just amend the test to use external storage
on android since it is explicitly trying to write...

stand by.

[tim (not reviewing), 2014-07-22 20:03:01]

Actually it's simpler... I didn't realize there was a DIR_TEST_DATA in base/ as
well.  Seems like a better place than DIR_MODULE if all it needs is a place to
write to... 

+brettw for components/url_fixer
+sky for chrome/common
+phajdan.jr for base/test

[nyquist, 2014-07-22 20:14:24]

lgtm

[sky, 2014-07-22 21:20:13]

LGTM

[Paweł Hajdan Jr., 2014-07-23 10:33:02]

LGTM

[tim (not reviewing), 2014-07-23 19:56:24]

brettw: ping!

[brettw, 2014-07-23 20:03:08]

base rs lgtm

[tim (not reviewing), 2014-07-23 20:50:12]

On 2014/07/23 20:03:08, brettw wrote:
> base rs lgtm

sorry I should have repeated this from the mail I cc'ed you on: you're a
components/url_fixer owner which is what I needed.  But if you're cool w/ the
base path changes I'll take that to mean it works for URLFixer :) lmk if not,
otherwise committing.

[tim (not reviewing), 2014-07-23 20:50:15]

The CQ bit was checked by tim@chromium.org

[commit-bot: I haz the power, 2014-07-23 20:51:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tim@chromium.org/408063002/40001

[commit-bot: I haz the power, 2014-07-23 23:36:15]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[tim (not reviewing), 2014-07-24 01:08:55]

Committed patchset #2 manually as r285096 (presubmit successful).

[jamesr, 2014-07-24 06:12:46]

(was looking at random bot failures)

I think this broke ios tests:

http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29...

[ RUN      ] URLFixerTest.FixupFile
[4907:2315:0723/182713:1181013710167:FATAL:path_service.cc(212)] Check failed:
path.empty(). provider should not have modified path
0   components_unittests                0x015feebf
base::debug::StackTrace::StackTrace() + 63
1   components_unittests                0x015fee5b
base::debug::StackTrace::StackTrace() + 43
2   components_unittests                0x0167d66d
logging::LogMessage::~LogMessage() + 77
3   components_unittests                0x0167c33b
logging::LogMessage::~LogMessage() + 43
4   components_unittests                0x016f4476 PathService::Get(int,
base::FilePath*) + 1558
5   components_unittests                0x00a46c88
URLFixerTest_FixupFile_Test::TestBody() + 88
...


oddly enough the bot still looks green after this, even though this step is
failing and it's not green on the waterfall.

[tim (not reviewing), 2014-07-24 06:22:09]

On 2014/07/24 06:12:46, jamesr wrote:
> (was looking at random bot failures)
> 
> I think this broke ios tests:
> 
>
http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29...
> 
> [ RUN      ] URLFixerTest.FixupFile
> [4907:2315:0723/182713:1181013710167:FATAL:path_service.cc(212)] Check failed:
> path.empty(). provider should not have modified path
> 0   components_unittests                0x015feebf
> base::debug::StackTrace::StackTrace() + 63
> 1   components_unittests                0x015fee5b
> base::debug::StackTrace::StackTrace() + 43
> 2   components_unittests                0x0167d66d
> logging::LogMessage::~LogMessage() + 77
> 3   components_unittests                0x0167c33b
> logging::LogMessage::~LogMessage() + 43
> 4   components_unittests                0x016f4476 PathService::Get(int,
> base::FilePath*) + 1558
> 5   components_unittests                0x00a46c88
> URLFixerTest_FixupFile_Test::TestBody() + 88
> ...
> 
> 
> oddly enough the bot still looks green after this, even though this step is
> failing and it's not green on the waterfall.

uh oh... will revert for now since I can't look into it at the moment.

[tim (not reviewing), 2014-07-24 06:23:53]

A revert of this CL has been created in
https://codereview.chromium.org/417943002/ by tim@chromium.org.

The reason for reverting is: 
Need to fix components_unittests on iOS simulator (try was green, but test
actually failed).