Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 408053002: Remove unused allowWebComponents method from ContentSettingsObserver (Closed)

Created:
6 years, 5 months ago by adamk
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Remove unused allowWebComponents method from ContentSettingsObserver This method is never called from Blink ("web components" are always enabled). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M chrome/renderer/content_settings_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/content_settings_observer.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
adamk
6 years, 5 months ago (2014-07-21 22:39:07 UTC) #1
adamk
Darin, ping?
6 years, 5 months ago (2014-07-23 19:01:26 UTC) #2
darin (slow to review)
lgtm
6 years, 5 months ago (2014-07-23 19:17:00 UTC) #3
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 5 months ago (2014-07-23 19:50:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/408053002/1
6 years, 5 months ago (2014-07-23 19:53:19 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 20:54:02 UTC) #6
Message was sent while issue was closed.
Change committed as 285037

Powered by Google App Engine
This is Rietveld 408576698