[Sync] Fix namespace for sync_driver component

[Sync] Fix namespace for sync_driver component

browser_sync namespace was still in use while transitions were being made.
We're far enough along now that it's worth moving to the sync_driver namespace.

BUG=339728
TBR=bauerb@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284799

[maxbogue, 2014-07-21 22:14:21]

Overall looks good.

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_components_factory.h (right):

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_components_factory.h:43: }
Unrelated to your change, but missing "// namespace syncer" here and for history
below.

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_components_factory_impl.cc (right):

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_components_factory_impl.cc:110: using
sync_driver::ProxyDataTypeController;
Looks like this one should be down with the rest of the sync_driver:: block.

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_service.cc (right):

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_service.cc:499:
sync_driver::DataTypeController::StateMap* state_map) const {
Is the prefix necessary? There's a using line at the top. If it's not, the next
three changes in this file can be updated as well.

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_service.h (right):

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_service.h:78: }
// namespace sync_driver

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_service_autofill_unittest.cc (right):

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_service_autofill_unittest.cc:378: virtual
sync_driver::DataTypeController* CreateDataTypeController(
Covered by 'using'; also applies to most of the changes below this.

https://codereview.chromium.org/408003002/diff/20001/components/sync_driver/f...
File components/sync_driver/fake_data_type_controller.h (right):

https://codereview.chromium.org/408003002/diff/20001/components/sync_driver/f...
components/sync_driver/fake_data_type_controller.h:72: 
Extra line? Or maybe it's the newline that's supposed to be there; hard to tell.

[Nicolas Zea, 2014-07-21 22:23:31]

Comments addressed, PTAL

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_components_factory.h (right):

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_components_factory.h:43: }
On 2014/07/21 22:14:21, maxbogue wrote:
> Unrelated to your change, but missing "// namespace syncer" here and for
history
> below.

Done.

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_components_factory_impl.cc (right):

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_components_factory_impl.cc:110: using
sync_driver::ProxyDataTypeController;
On 2014/07/21 22:14:21, maxbogue wrote:
> Looks like this one should be down with the rest of the sync_driver:: block.

Done.

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_service.cc (right):

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_service.cc:499:
sync_driver::DataTypeController::StateMap* state_map) const {
On 2014/07/21 22:14:21, maxbogue wrote:
> Is the prefix necessary? There's a using line at the top. If it's not, the
next
> three changes in this file can be updated as well.

Done, here and below.

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_service.h (right):

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_service.h:78: }
On 2014/07/21 22:14:21, maxbogue wrote:
> // namespace sync_driver

Done.

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_service_autofill_unittest.cc (right):

https://codereview.chromium.org/408003002/diff/20001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_service_autofill_unittest.cc:378: virtual
sync_driver::DataTypeController* CreateDataTypeController(
On 2014/07/21 22:14:21, maxbogue wrote:
> Covered by 'using'; also applies to most of the changes below this.

Done.

https://codereview.chromium.org/408003002/diff/20001/components/sync_driver/f...
File components/sync_driver/fake_data_type_controller.h (right):

https://codereview.chromium.org/408003002/diff/20001/components/sync_driver/f...
components/sync_driver/fake_data_type_controller.h:72: 
On 2014/07/21 22:14:21, maxbogue wrote:
> Extra line? Or maybe it's the newline that's supposed to be there; hard to
tell.

Extra line. Removed.

[maxbogue, 2014-07-21 22:28:03]

LGTM.

https://codereview.chromium.org/408003002/diff/60001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_components_factory.h (right):

https://codereview.chromium.org/408003002/diff/60001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_components_factory.h:47: }
// namespace history

[Nicolas Zea, 2014-07-21 22:35:59]

Comments addressed. +TBR Bernhard for
supervised_user_sync_data_type_controller.[h,cc/.

Committing.

https://codereview.chromium.org/408003002/diff/60001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_components_factory.h (right):

https://codereview.chromium.org/408003002/diff/60001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_components_factory.h:47: }
On 2014/07/21 22:28:03, maxbogue wrote:
> // namespace history

Done.

[Nicolas Zea, 2014-07-21 22:36:09]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2014-07-21 22:40:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zea@chromium.org/408003002/80001

[commit-bot: I haz the power, 2014-07-22 01:25:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)

[commit-bot: I haz the power, 2014-07-22 01:27:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 01:27:09]

Try jobs failed on following builders:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)

[Bernhard Bauer, 2014-07-22 08:09:46]

supervised_user/ LGTM

[Nicolas Zea, 2014-07-22 18:46:57]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2014-07-22 18:48:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zea@chromium.org/408003002/100001

[commit-bot: I haz the power, 2014-07-22 23:26:55]

Change committed as 284799