Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 408: Fix an out of band read when parsing a URL component of just "%". The... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 7 months ago by Dean McNamee
Modified:
3 years, 11 months ago
Reviewers:
brettw, M-A Ruel
CC:
chromium-reviews_googlegroups.com, sky
Visibility:
Public.

Description

Fix an out of band read when parsing a URL component of just "%". The calculation of max_digit_index is unsigned, and was underflowing when max was less than 2. BUG=122 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1677

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M net/base/escape.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/base/escape_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 1 (0 generated)
Dean McNamee
6 years, 7 months ago (2008-09-03 10:45:15 UTC) #1
I just fixed the single case, and I'm not sure it's 100%.  This is actually
sky's code, but reviewing to brettw.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e0e3771