Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 407953002: Support setting named properties on non-JSObjects. (Closed)

Created:
6 years, 5 months ago by Toon Verwaest
Modified:
6 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

Support setting named properties on non-JSObjects. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22518

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -79 lines) Patch
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic.cc View 6 chunks +19 lines, -25 lines 0 comments Download
M src/liveedit.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/objects.h View 3 chunks +7 lines, -15 lines 0 comments Download
M src/objects.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M src/runtime.cc View 6 chunks +16 lines, -13 lines 0 comments Download
M test/mjsunit/value-wrapper-accessor.js View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 5 months ago (2014-07-21 13:45:15 UTC) #1
Igor Sheludko
lgtm
6 years, 5 months ago (2014-07-22 08:22:16 UTC) #2
Toon Verwaest
6 years, 5 months ago (2014-07-22 08:28:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22518 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698